Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(adhoc)(platform-support) Add logs for debugging the entity detection issue for NSDC #544

Merged
merged 5 commits into from
Oct 26, 2023

Conversation

haptikrajasashtikar
Copy link
Contributor

JIRA Ticket Number

JIRA TICKET: https://hello-haptik.atlassian.net/browse/BB-11092

Description of change

  • Add logger to check the request data and the result of ES queries

Checklist (OPTIONAL):

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@haptik-deployment
Copy link

👍 No lint errors found.

@haptik-deployment
Copy link

👍 No lint errors found.

@haptik-deployment
Copy link

👍 No lint errors found.

@haptik-deployment
Copy link

👍 No lint errors found.

@haptik-deployment
Copy link

👍 No lint errors found.

@haptik-deployment
Copy link

👍 No lint errors found.

@haptik-deployment
Copy link

👍 No lint errors found.

rootAvish
rootAvish previously approved these changes Oct 25, 2023
@haptik-deployment
Copy link

👍 No lint errors found.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@haptik-deployment
Copy link

UNIT TESTS HAVE PASSED... Good To Merge

@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

Attention: 519 lines in your changes are missing coverage. Please review.

Comparison is base (7421047) 41.96% compared to head (56fb55d) 40.54%.
Report is 151 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #544      +/-   ##
==========================================
- Coverage   41.96%   40.54%   -1.43%     
==========================================
  Files          79       81       +2     
  Lines        8869     9444     +575     
==========================================
+ Hits         3722     3829     +107     
- Misses       5147     5615     +468     
Files Coverage Δ
...etectors/pattern/regex/data/character_constants.py 100.00% <100.00%> (ø)
ner_v1/detectors/textual/name/lang_constants.py 100.00% <100.00%> (ø)
ner_v1/detectors/textual/text/text_detection.py 15.59% <100.00%> (ø)
ner_v2/detectors/base_detector.py 28.40% <ø> (ø)
ner_v2/detectors/numeral/constant.py 100.00% <100.00%> (ø)
ner_v2/detectors/textual/text_detection.py 85.09% <100.00%> (+0.04%) ⬆️
ner_v2/detectors/textual/utils.py 88.46% <100.00%> (+1.31%) ⬆️
ner_v1/api.py 22.60% <75.00%> (ø)
ner_v1/chatbot/entity_detection.py 21.60% <66.66%> (ø)
ner_v1/detectors/pattern/regex/regex_detection.py 88.13% <87.50%> (-0.55%) ⬇️
... and 14 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@haptikrajasashtikar haptikrajasashtikar merged commit 81aa200 into master Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants