Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added logs for text entity detection #554

Merged
merged 1 commit into from
Oct 30, 2023
Merged

Added logs for text entity detection #554

merged 1 commit into from
Oct 30, 2023

Conversation

imankur
Copy link
Contributor

@imankur imankur commented Oct 30, 2023

JIRA Ticket Number

JIRA TICKET: https://hello-haptik.atlassian.net/browse/BB-11089

Description of change

Added logs for text entity detection

Checklist (OPTIONAL):

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@haptik-deployment
Copy link

👍 No lint errors found.

@sonarcloud
Copy link

sonarcloud bot commented Oct 30, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@shivanid29
Copy link

Approving the PR, no QA needed

@haptik-deployment
Copy link

UNIT TESTS HAVE PASSED... Good To Merge

@codecov
Copy link

codecov bot commented Oct 30, 2023

Codecov Report

Attention: 14 lines in your changes are missing coverage. Please review.

Comparison is base (f2046c8) 40.46% compared to head (3f8d6f7) 40.48%.
Report is 29 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #554      +/-   ##
===========================================
+ Coverage    40.46%   40.48%   +0.02%     
===========================================
  Files           81       81              
  Lines         9441     9468      +27     
===========================================
+ Hits          3820     3833      +13     
- Misses        5621     5635      +14     
Files Coverage Δ
ner_v2/detectors/textual/text_detection.py 85.29% <100.00%> (+0.24%) ⬆️
ner_v2/detectors/textual/utils.py 88.46% <100.00%> (+1.31%) ⬆️
ner_v2/api.py 8.08% <0.00%> (-0.03%) ⬇️
ner_v2/detectors/textual/elastic_search.py 63.10% <0.00%> (-9.12%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@imankur imankur merged commit ac8260a into develop Oct 30, 2023
8 checks passed
@ganeshhaptik ganeshhaptik mentioned this pull request Oct 8, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants