Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added logs for regex #555

Merged
merged 1 commit into from
Sep 2, 2024
Merged

added logs for regex #555

merged 1 commit into from
Sep 2, 2024

Conversation

imankur
Copy link
Contributor

@imankur imankur commented Sep 2, 2024

JIRA Ticket Number

JIRA TICKET:

Description of change

  • added logs for regex

Checklist (OPTIONAL):

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@haptik-deployment
Copy link

👍 No lint errors found.

@haptik-deployment
Copy link

UNIT TESTS HAVE PASSED... Good To Merge

Copy link

codecov bot commented Sep 2, 2024

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 40.47%. Comparing base (6b86fb8) to head (35567d4).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
ner_v1/chatbot/entity_detection.py 0.00% 3 Missing ⚠️
ner_v1/api.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #555      +/-   ##
==========================================
- Coverage   40.49%   40.47%   -0.03%     
==========================================
  Files          81       81              
  Lines        9455     9460       +5     
==========================================
  Hits         3829     3829              
- Misses       5626     5631       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@imankur imankur requested a review from a team September 2, 2024 09:34
@imankur imankur merged commit d49fba4 into master Sep 2, 2024
5 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants