-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BAM-22413 Update publisher reporting docs #188
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I started making changes but we need to see how this builds because I think rst doesnt respect single line breaks so all the lists and stuff will currently come out jumbling
fdfff70
to
a816fca
Compare
Co-authored-by: Nat Taylor <nattaylor@gmail.com>
Co-authored-by: Nat Taylor <nattaylor@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made a few wording suggestions
To gain a comprehensive view of returns, we recommend aggregating the values for each unique combination of | ||
checkout_id, merchant and product_id (denoted by the order_product_id column) across all return files. | ||
|
||
Since this report is designed to be used to complement the data in the orders reports, the column 'order_product_id' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should it be a combination of checkout_id and order_product_id to join
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The event_product_id is a uniquely generated id for each entry in the events_products table so it should be unique to the combination of merchant+checkout_id+product_id.
Co-authored-by: Nat Taylor <nattaylor@gmail.com>
Add returns reporting information
Update introduction with all potential locations for report sharing
Add what to expect sections
Add example queries