This repository has been archived by the owner on Oct 17, 2023. It is now read-only.
Express and expect declared as runtime dependencies #89
Labels
legacy
Related to legacy, non-OpenAPI SDK
I noticed when upgrading hellosign-sdk recently that
express
andexpect
are both declared as depedencies, rather than devDependencies. This causes a lot of unwanted runtime deps to get pulled into apps that use hellosign-sdk.It looks like
expect
is only used in tests, butexpress
is used in server.js for what looks like a Hello World example. Maybe server.js should move into thetest/
folder, if it's used at all?I'm happy to put together a quick PR, too.
The text was updated successfully, but these errors were encountered: