Skip to content
This repository has been archived by the owner on Oct 17, 2023. It is now read-only.

Express and expect declared as runtime dependencies #89

Open
jekh opened this issue Feb 26, 2021 · 2 comments
Open

Express and expect declared as runtime dependencies #89

jekh opened this issue Feb 26, 2021 · 2 comments
Labels
legacy Related to legacy, non-OpenAPI SDK

Comments

@jekh
Copy link

jekh commented Feb 26, 2021

I noticed when upgrading hellosign-sdk recently that express and expect are both declared as depedencies, rather than devDependencies. This causes a lot of unwanted runtime deps to get pulled into apps that use hellosign-sdk.

It looks like expect is only used in tests, but express is used in server.js for what looks like a Hello World example. Maybe server.js should move into the test/ folder, if it's used at all?

I'm happy to put together a quick PR, too.

 "dependencies": {
    "expect": "^24.9.0",
    "express": "^4.17.1",
    "form-data": "^2.3.2",
    "when": "~3.1.0"
  },
@gabegorelick
Copy link
Contributor

Related PR: #99

@miguelriosoliveira
Copy link

Please accept PR #99 🙏
The warnings that hellosign-sdk brings to the project are really annoying 😪

@jtreminio-dropbox jtreminio-dropbox added the legacy Related to legacy, non-OpenAPI SDK label Mar 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
legacy Related to legacy, non-OpenAPI SDK
Projects
None yet
Development

No branches or pull requests

4 participants