This repository has been archived by the owner on Oct 17, 2023. It is now read-only.
Move 'expect' to devDependencies in package.json #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Charaka Gunatillake <charakajg@gmail.com>
charakajg
changed the title
|
Please accept this PR 🙏 |
miguelriosoliveira
previously approved these changes
Feb 18, 2022
|
@nathanbuchar can we get a review/merge for this? |
|
|
miguelriosoliveira
approved these changes
Apr 15, 2023
|
@jtreminio-dropbox This PR requires an approval from a reviewer with write access. Hope we can merge this, although it's deprecated. |
|
Please use the new OpenAPI SDK: https://www.npmjs.com/package/@dropbox/sign |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
The "expect" library is only used in test files. However, in package.json, it has incorrectly listed as a dependency instead of as dev dependancy. Therefore, whenever someone who uses this hellosign-nodejs-sdk library runs "npm audit --production", it incorrectly shows any issues with "expect" library, although it's not used in production.
Fix
Here, the "expect" library has been moved to its rightful place "devDependencies" in package.json