Bug: Error creation crashing in Client#prepare_files

[DanielDe]

I'm getting a crash when passing an invalid path for the files parameter in create_embedded_signature_request:

ArgumentError: wrong number of arguments (given 1, expected 2..3)
from /Users/danieldehaas/.rvm/gems/ruby-2.4.4@duco/gems/hellosign-ruby-sdk-3.7.7/lib/hello_sign/error.rb:30:in `initialize'

The problem seems to be in these two places:

• https://github.com/HelloFax/hellosign-ruby-sdk/blob/v3/lib/hello_sign/client.rb#L224
• https://github.com/HelloFax/hellosign-ruby-sdk/blob/v3/lib/hello_sign/client.rb#L235

The Error initializer expects 2 to 3 arguments but is only getting 1.

Thanks!

[sikandartariq1]

fixed in this pull request #107

[Hussainbhatti1]

Please merge this fix.

[danfstucky]

It's been over a year, why has this fix not been merged yet? Initializing errors straight up does not work.

[johnnycupcakes]

Thank you for letting me know, pull request #107 has been merged.

[syed-mohsin]

@johnnycupcakes This fix is part of v 3.7.10 which hasn't been released yet. How can i specify this version in my Gemfile?

[alexmac05]

i'm looking into this and will get back to you. sorry for the delay.

[sallyhall]

#107 allows errors to be initialized, but the way errors are initialized here:

• https://github.com/HelloFax/hellosign-ruby-sdk/blob/v3/lib/hello_sign/client.rb#L224
• https://github.com/HelloFax/hellosign-ruby-sdk/blob/v3/lib/hello_sign/client.rb#L235

a message is passed to the error class, but is interpreted as the status, creating a confusing human readable message.