Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Helm 3 #22

Merged
merged 1 commit into from
Mar 21, 2020
Merged

Add support for Helm 3 #22

merged 1 commit into from
Mar 21, 2020

Conversation

unguiculus
Copy link
Member

At the same time we drop support for Helm 2. Since actions are a new thing
and we don't have a major release yet, we decided to not support legacy.
Helm 2 users can still use older releases.

Signed-off-by: Reinhard Naegele unguiculus@gmail.com

Copy link
Member

@scottrigby scottrigby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks perf 👌

@@ -133,21 +130,6 @@ configure_kube() {
docker cp "$kubeconfig" ct:/root/.kube/config
}

install_tiller() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹

@unguiculus unguiculus force-pushed the helm3-support branch 2 times, most recently from 21eade4 to 053803f Compare March 21, 2020 15:53
@scottrigby
Copy link
Member

I created a dev-v2 branch. We probably shouldn't say we're dropping support for helm 2 entirely, just that it's going into security fixes only mode or something. The branch is there if people want to contribute PRs.

At the same time we drop support for Helm 2. Since actions are a new thing
and we don't have a major release yet, we decided to not support legacy.
Helm 2 users can still use older releases.

Signed-off-by: Reinhard Naegele <unguiculus@gmail.com>
@@ -2,6 +2,9 @@

A GitHub Action to lint and test Helm charts, using the [helm/chart-testing](https://github.com/helm/chart-testing) CLI tool.

`master` supports Helm 3 only.
Support for Helm 2 is on branch `dev-v2`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants