Skip to content

Fix helm-extra-set-args in YAML configuration #713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 3, 2025

Conversation

arbourd
Copy link
Contributor

@arbourd arbourd commented Feb 8, 2025

What this PR does / why we need it:

Allows the usage of helm-extra-set-args key from a ct.yaml and not just command-line flags.

Currently, helm-extra-set-args is only available as a command-line flag, despite being part of the config object. This does not appear to be documented.

This change sources the value extraSetArgs via the config object rather than the cmd.Flags() only.

This PR adds the configuration option but it is never used: #697

Copy link

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@github-actions github-actions bot added the Stale label Mar 25, 2025
@arbourd
Copy link
Contributor Author

arbourd commented Mar 25, 2025

Can we unstale this? It's still needed.

@github-actions github-actions bot removed the Stale label Mar 26, 2025
@arbourd
Copy link
Contributor Author

arbourd commented Apr 8, 2025

@unguiculus Is it possible to get this fix in, please?

@DaruZero
Copy link
Contributor

+1 on this fix

@cpanato
Copy link
Member

cpanato commented Jun 2, 2025

@arbourd can you rebase?

Verified

This commit was signed with the committer’s verified signature.
arbourd Dylan Arbour
Currently, `helm-extra-set-args` is only available as a command-line
flag, despite being part of the config object. This does not appear to
be documented.

This changes sources the value `extraSetArgs` via the `config` object
rather than the cmd.Flags() only.

Signed-off-by: Dylan Arbour <arbourd@users.noreply.github.com>
@arbourd arbourd force-pushed the fix-extra-set-args branch from c57e911 to 97d7b06 Compare June 2, 2025 16:27
@arbourd
Copy link
Contributor Author

arbourd commented Jun 2, 2025

@cpanato Done.

Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

thanks

@cpanato cpanato merged commit d576e67 into helm:main Jun 3, 2025
4 checks passed
@arbourd
Copy link
Contributor Author

arbourd commented Jun 3, 2025

No, thank you! Appreciate it.

@arbourd arbourd deleted the fix-extra-set-args branch June 3, 2025 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants