-
Notifications
You must be signed in to change notification settings - Fork 241
Fix helm-extra-set-args
in YAML configuration
#713
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
b430659
to
c57e911
Compare
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
Can we unstale this? It's still needed. |
@unguiculus Is it possible to get this fix in, please? |
+1 on this fix |
@arbourd can you rebase? |
Currently, `helm-extra-set-args` is only available as a command-line flag, despite being part of the config object. This does not appear to be documented. This changes sources the value `extraSetArgs` via the `config` object rather than the cmd.Flags() only. Signed-off-by: Dylan Arbour <arbourd@users.noreply.github.com>
c57e911
to
97d7b06
Compare
@cpanato Done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
thanks
No, thank you! Appreciate it. |
What this PR does / why we need it:
Allows the usage of
helm-extra-set-args
key from act.yaml
and not just command-line flags.Currently,
helm-extra-set-args
is only available as a command-line flag, despite being part of the config object. This does not appear to be documented.This change sources the value
extraSetArgs
via theconfig
object rather than the cmd.Flags() only.This PR adds the configuration option but it is never used: #697