Update index.go #748
Open
Update index.go #748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the chartversions of index.yaml should be equal to the length of chartversion objects in storage backend. if not equal, we should regenerate the index.yaml. Signed-off-by: Xiaolei.Liang <xiaolei.liang@qq.com> Signed-off-by: liangxiaolei5 <liangxiaolei@jd.com>
wutongjie23hao
force-pushed
the
patch-2
branch
from
ab5caf7
to
4d51574
Compare
added 2 commits
January 31, 2024 09:56
Signed-off-by: liangxiaolei5 <liangxiaolei@jd.com>
Signed-off-by: liangxiaolei5 <liangxiaolei@jd.com>
wutongjie23hao
force-pushed
the
patch-2
branch
from
eab50f6
to
ebf43af
Compare
|
I prefer to not accept this PR , since we already have internal-cache option and always-regenerate-chart-index option on the other hand , this kind of feature seems duplicate . What do you think ? @cbuto |
always regenerate index only when the depth set a certain value. This is not valid when we set flag '--depth-dynamic'. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the chartversions of index.yaml should be equal to the length of chartversion objects in storage backend. if not equal, we should regenerate the index.yaml.