This repository has been archived by the owner on Feb 22, 2022. It is now read-only.
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
stable/datadog - Set DD_APM_ENABLED to false in container-agent.yaml …
…template (#21510) * enable deployment annotations, bump chart version (#21502) Signed-off-by: Ryan Holt <ryan@ryanholt.net> Signed-off-by: Omer Lifshitz <omer.lifshitz@datadoghq.com> * [stable/datalog] Do not enable the `cri` check when running on a `docker` setup (#21476) Signed-off-by: Lénaïc Huard <lenaic.huard@datadoghq.com> Signed-off-by: Omer Lifshitz <omer.lifshitz@datadoghq.com> * [stable/datadog] Add some missing syscalls to the `system-probe` seccomp profile (#21456) The added syscalls are syscalls that an unconfined `system-probe` would do. Signed-off-by: Lénaïc Huard <lenaic.huard@datadoghq.com> Signed-off-by: Omer Lifshitz <omer.lifshitz@datadoghq.com> * [stable/minio] corrected syntax error in statefulset (#21503) * corrected syntax error in statefulset Signed-off-by: Thomas Wilkinson <thomas.wilkinson@us.ibm.com> * chart version bump Signed-off-by: Thomas Wilkinson <thomas.wilkinson@us.ibm.com> Signed-off-by: Omer Lifshitz <omer.lifshitz@datadoghq.com> * [stable/redis-ha] Make emptyDir configurable from values (#21489) Signed-off-by: Jeroen Castelein <jeroencastelein11@gmail.com> Signed-off-by: Omer Lifshitz <omer.lifshitz@datadoghq.com> * Set DD_APM_ENABLED With the new Helm chart, even if `datadog.apm.enabled` is set to false, it reverts to the docker defaults (true). Having the trace-agent running in the background is pretty harmless from a resource overhead standpoint, however, the logic of the helm chart will automatically do the 8126 port-forwarding, and since we don't want non-apm customers to have this port exposed, we need to respect the chart settings. Signed-off-by: Omer Lifshitz <omer.lifshitz@datadoghq.com> * Bumped version Signed-off-by: Omer Lifshitz <omer.lifshitz@datadoghq.com> * 2.0.12 Fixed a bug where datadog.apm.enabled was not being respected Signed-off-by: Omer Lifshitz <omer.lifshitz@datadoghq.com> * re-applying the changes Signed-off-by: Omer Lifshitz <omer.lifshitz@datadoghq.com> Co-authored-by: Ryan Holt <ryan@ryanholt.net> Co-authored-by: Lénaïc Huard <L3n41c@users.noreply.github.com> Co-authored-by: Thomas Wilkinson <thomas@capnajax.com> Co-authored-by: Jeroen Castelein <jeroen.castelein@kpn.com>
- Loading branch information
0e8c700
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This effectively means that I have to manually set the DD_APM_ENABLED envvar to be able to use APM now. I'm not sure why this isn't wrapped in a conditional. Setting it false all the time doesn't seem to be in the spirit of respecting enabling/disabling of APM. Is there any concern that setting the envar will have undeterministic behavior?