Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

Commit

Permalink
[stable/nginx-ingress] make PDB, autoscaling and GitOps play nice wit…
Browse files Browse the repository at this point in the history
…h each other (#19073)

When deploying the NGINX ingress controller including autoscler via Flux, you usually don’set the replicaCount.
Flux and the autoscaler interfere with each other as flux would keep changing the number of replicas to the desired values, too. By just not setting the replicaCount, you lose the pod disruption budget. With this change, you can have all three: autoscaler, GitOps deployment and a por disruption budget.

Signed-off-by: Hendrik M Halkow <hendrik@halkow.com>
  • Loading branch information
hendrikhalkow authored and k8s-ci-robot committed Nov 25, 2019
1 parent fe6c09b commit 3eedc8f
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion stable/nginx-ingress/Chart.yaml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
apiVersion: v1
name: nginx-ingress
version: 1.25.0
version: 1.25.1
appVersion: 0.26.1
home: https://github.com/kubernetes/ingress-nginx
description: An nginx Ingress controller that uses ConfigMap to store the nginx configuration.
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{{- if gt (.Values.controller.replicaCount | int) 1 }}
{{- if or (and .Values.controller.autoscaling.enabled (gt (.Values.controller.autoscaling.minReplicas | int) 1)) (gt (.Values.controller.replicaCount | int) 1) }}
apiVersion: policy/v1beta1
kind: PodDisruptionBudget
metadata:
Expand Down

0 comments on commit 3eedc8f

Please sign in to comment.