Fix clusterIP assignment (#7435)

Signed-off-by: Nitish <nitish@minio.io>
helm · Sep 4, 2018 · 43e7da2 · 43e7da2
1 parent 142b8a4
commit 43e7da2
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 8 deletions.
diff --git a/stable/minio/Chart.yaml b/stable/minio/Chart.yaml
@@ -1,8 +1,8 @@
 apiVersion: v1
 description: Minio is a high performance distributed object storage server, designed for large-scale private cloud infrastructure.
 name: minio
-version: 1.6.3
-appVersion: RELEASE.2018-08-25T01-56-38Z
+version: 1.6.4
+appVersion: RELEASE.2018-09-01T00-38-25Z
 keywords:
 - storage
 - object-storage

diff --git a/stable/minio/README.md b/stable/minio/README.md
@@ -76,7 +76,7 @@ The following table lists the configurable parameters of the Minio chart and the
 | Parameter                  | Description                         | Default                                                 |
 |----------------------------|-------------------------------------|---------------------------------------------------------|
 | `image.repository`         | Image repository                    | `minio/minio`                                           |
-| `image.tag`                | Minio image tag. Possible values listed [here](https://hub.docker.com/r/minio/minio/tags/).| `RELEASE.2018-08-25T01-56-38Z`|
+| `image.tag`                | Minio image tag. Possible values listed [here](https://hub.docker.com/r/minio/minio/tags/).| `RELEASE.2018-09-01T00-38-25Z`|
 | `image.pullPolicy`         | Image pull policy                   | `IfNotPresent`                                          |
 | `mcImage.repository`       | Client image repository             | `minio/mc`                                              |
 | `mcImage.tag`              | mc image tag. Possible values listed [here](https://hub.docker.com/r/minio/mc/tags/).| `RELEASE.2018-08-18T02-13-04Z`|

diff --git a/stable/minio/templates/service.yaml b/stable/minio/templates/service.yaml
@@ -14,7 +14,7 @@ metadata:
 spec:
 {{- if (or (eq .Values.service.type "ClusterIP" "") (empty .Values.service.type)) }}
   type: ClusterIP
-  {{- if .Values.service.clusterIP }}
+  {{- if not (empty .Values.service.clusterIP) }}
   clusterIP: {{ .Values.service.clusterIP }}
   {{end}}
 {{- else if eq .Values.service.type "LoadBalancer" }}

diff --git a/stable/minio/values.yaml b/stable/minio/values.yaml
@@ -2,7 +2,7 @@
 ##
 image:
   repository: minio/minio
-  tag: RELEASE.2018-08-25T01-56-38Z
+  tag: RELEASE.2018-09-01T00-38-25Z
   pullPolicy: IfNotPresent
 
 ## Set default image, imageTag, and imagePullPolicy for the `mc` (the minio
@@ -69,7 +69,7 @@ persistence:
 
 service:
   type: ClusterIP
-  clusterIP: None
+  clusterIP: ~
   port: 9000
   # nodePort: 31311
   annotations: {}
@@ -138,9 +138,9 @@ nasgateway:
   enabled: false
   # Number of parallel instances
   replicas: 4
-  # Generally for NAS Gateway, you'd like to bind the PVC to a specific PV. To ensure that happens, PV to bind to should have
+  # For NAS Gateway, you may want to bind the PVC to a specific PV. To ensure that happens, PV to bind to should have
   # a label like "pv: <value>", use value here.
-  pv: ""
+  pv: ~
 
 ## https://docs.minio.io/docs/minio-bucket-notification-guide
 ## https://github.com/minio/minio/blob/master/docs/config