Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

Commit

Permalink
Fix scheme assignment and selector labels for statefulset headless svc (
Browse files Browse the repository at this point in the history
#19494)

Signed-off-by: Nitish Tiwari <nitish@min.io>
  • Loading branch information
nitisht authored and k8s-ci-robot committed Dec 10, 2019
1 parent be8ab92 commit 5b77af2
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
4 changes: 2 additions & 2 deletions stable/minio/Chart.yaml
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
apiVersion: v1
description: MinIO is a high performance distributed object storage server, designed for large-scale private cloud infrastructure.
name: minio
version: 3.0.3
appVersion: RELEASE.2019-08-07T01-59-21Z
version: 3.0.4
appVersion: master
keywords:
- storage
- object-storage
Expand Down
3 changes: 2 additions & 1 deletion stable/minio/templates/statefulset.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
{{ $nodeCount := .Values.replicas | int }}
{{ $scheme := "http" }}
{{- if .Values.tls.enabled }}
{{ $scheme = "https" }}
{{ $scheme := "https" }}

This comment has been minimized.

Copy link
@briend

briend Mar 10, 2020

Contributor

Was the ":=" intentional? The := operator seems to declare a new $scheme variable that is only scoped within the IF block. Until I changed this, $scheme was always "http" regardless of tls.enabled. I opened a PR for this #21373

{{ end }}
apiVersion: v1
kind: Service
Expand All @@ -22,6 +22,7 @@ spec:
protocol: TCP
selector:
app: {{ template "minio.name" . }}
release: {{ .Release.Name }}
---
apiVersion: {{ template "minio.statefulset.apiVersion" . }}
kind: StatefulSet
Expand Down

0 comments on commit 5b77af2

Please sign in to comment.