[stable/prometheus-adapter] Do not create custom metrics rbac

Commit b7afaf9 ("do not create apiservice when not needed") from PR #20883 disabled the custom API Service when no custom rules are used. However, we also need to not deploy the cluster role as it has no use. Signed-off-by: Markos Chandras <markos@chandras.me>
helm · Feb 25, 2020 · 8181871 · 8181871
1 parent a63e681
commit 8181871
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/stable/prometheus-adapter/Chart.yaml b/stable/prometheus-adapter/Chart.yaml
@@ -1,6 +1,6 @@
 apiVersion: v1
 name: prometheus-adapter
-version: 2.1.2
+version: 2.1.3
 appVersion: v0.6.0
 description: A Helm chart for k8s prometheus adapter
 home: https://github.com/DirectXMan12/k8s-prometheus-adapter

diff --git a/stable/prometheus-adapter/templates/custom-metrics-cluster-role.yaml b/stable/prometheus-adapter/templates/custom-metrics-cluster-role.yaml
@@ -1,4 +1,4 @@
-{{- if .Values.rbac.create -}}
+{{- if and .Values.rbac.create (or .Values.rules.default .Values.rules.custom) -}}
 apiVersion: rbac.authorization.k8s.io/v1
 kind: ClusterRole
 metadata: