[stable/redis] Helm3 Upgrade Failing

[dominik-bln]

Describe the bug

When trying to upgrade a stable/redis release from Helm 2 to Helm 3, the initial conversion is working, but the next release fails due to an immutable statefulset issue.

Version of Helm and Kubernetes:

Helm v3.0.3
Kubernetes 1.17.2

Which chart:

stable/redis

What happened:

The StatefulSet "review-helm3-7yge49-redis-master" is invalid: spec: Forbidden: updates to statefulset spec for fields other than 'replicas', 'template', and 'updateStrategy' are forbidden

What you expected to happen:

The deploy should pass.

How to reproduce it (as minimally and precisely as possible):

Install a redis release with Helm2, use helm3 with the 2to3 plugin to convert the release and do a deploy with helm3.

Anything else we need to know:

My best guess is that this is a similar issue to #7803 and happening due to the fact that Helm3 changes heritage from Tiller to Helm, which in turn updates the volume claim template:

charts/stable/redis/templates/redis-master-statefulset.yaml

Line 389 in 9977a78

heritage: {{ .Release.Service }}

[dominik-bln]

Looks like there is a proposal on the Helm repo that could also fix this problem for us:

helm/helm#7211

[juan131]

Hi @dominik-bln

This issue was already reported for other chart and it's related to the label below which solves to Tiller in Helm2, and Helm in Helm3:

heritage: {{ .Release.Service | quote }} 

See:

• [feature] add option to force/override "Release.Service" back to "Tiller" helm#7211
• [stable/mariadb] stateful sets break with Helm v3 #19231

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions.

[dominik-bln]

This issue is not stale. Still a blocker for the Helm3 update for us.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions.

[stale]

This issue is being automatically closed due to inactivity.