Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

Redis helm3 migration compatibility #23870

Conversation

alice-sawatzky
Copy link
Contributor

What this PR does / why we need it:

When upgrading from a helm2 release using helm 2to3, helm3 upgrades fail because .Release.Service changed, causing helm to attempt to modify the (immutable) heritage label on the Statefulset's VolumeClaimTemplate. This provides a flag to set it back to "Tiller" to allow for upgrades.

Which issue this PR fixes

Checklist

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md
  • Title of the PR starts with chart name (e.g. [stable/mychartname])

Signed-off-by: Alice Sawatzky <alice.sawatzky@farmersedge.ca>
Signed-off-by: Alice Sawatzky <alice.sawatzky@farmersedge.ca>
@helm-bot helm-bot added Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 9, 2020
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 9, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @alice-sawatzky. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: alice-sawatzky
To complete the pull request process, please assign prydonius after the PR has been reviewed.
You can assign the PR to them by writing /assign @prydonius in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@alice-sawatzky
Copy link
Contributor Author

Better workaround: kubectl delete the offending statefulsets with --cascade=false.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[stable/redis] Helm3 Upgrade Failing
3 participants