Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/atlantis] Most recent version breaks multiline values in AWS credentials #21855

Closed
bmckalla opened this issue Apr 9, 2020 · 3 comments
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@bmckalla
Copy link

bmckalla commented Apr 9, 2020

Describe the bug
On the most recent commit/version update, toYaml was used which broke multiline strings.

Version of Helm and Kubernetes:
Helm: client v2.16.5 - server v2.16.1
Kube: client v1.17.2 - server v1.14.9-eks-502bfb

Which chart:
[stable/atlantis] secret-aws.yaml

What happened:
If you do something like:

aws:
    credentials: |
        [default]
        aws_access_key_id=SOME_ACCESS_KEY
        aws_secret_access_key=SOME_SECRET
        region=REGION

It will then format the /home/atlantis/.aws/config as:

 |
        [default]
        aws_access_key_id=SOME_ACCESS_KEY
        aws_secret_access_key=SOME_SECRET
        region=REGION

What you expected to happen:
It should be formatted as:

[default]
aws_access_key_id=SOME_ACCESS_KEY
aws_secret_access_key=SOME_SECRET
region=REGION

I think if you remove toYaml it should resolve the issue.

How to reproduce it (as minimally and precisely as possible):
See above

Anything else we need to know:
The values.yaml for Atlantis also specify to format it the way that I did

@KernCheh
Copy link

KernCheh commented May 5, 2020

#21554

@stale
Copy link

stale bot commented Jun 5, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions.

@stale stale bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 5, 2020
@stale
Copy link

stale bot commented Jun 20, 2020

This issue is being automatically closed due to inactivity.

@stale stale bot closed this as completed Jun 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Development

No branches or pull requests

2 participants