-
Notifications
You must be signed in to change notification settings - Fork 16.8k
[stable/atlantis] AWS credentials toYaml error #21554
Conversation
Signed-off-by: Scott Crooks <scott.crooks@gmail.com>
Hi @sc250024. Thanks for your PR. I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
@zanhsieh Okay to merge this bad boy? |
I ran into this as well trying to upgrade to Looking forward to getting this merged! |
@sc250024 @jkodroff |
/assign @sstarcher |
lgtm |
/approve I think the original PR before this should have been a |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jeff-knurek, sc250024 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Scott Crooks <scott.crooks@gmail.com>
Signed-off-by: Scott Crooks <scott.crooks@gmail.com>
Signed-off-by: Scott Crooks <scott.crooks@gmail.com> Signed-off-by: Adrien Loiseau <adrien.loiseau@logic-immo.com>
Signed-off-by: Scott Crooks <scott.crooks@gmail.com> Signed-off-by: Miguel Mingorance <miguel.mingorance@deliveryhero.com>
Signed-off-by: Scott Crooks scott.crooks@gmail.com
What this PR does / why we need it:
In the previous PR (#21305), I used
toYaml
, which is redundant, and leads to an error in the~/.aws/credentials
file if you're using a YAML multi-line string like so:This gets rendered as:
Which is wrong.
Which issue this PR fixes
N/A
Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
[stable/mychartname]
)