Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/atlantis] AWS credentials toYaml error #21554

Merged
merged 1 commit into from
Apr 24, 2020
Merged

[stable/atlantis] AWS credentials toYaml error #21554

merged 1 commit into from
Apr 24, 2020

Conversation

sc250024
Copy link
Contributor

Signed-off-by: Scott Crooks scott.crooks@gmail.com

What this PR does / why we need it:

In the previous PR (#21305), I used toYaml, which is redundant, and leads to an error in the ~/.aws/credentials file if you're using a YAML multi-line string like so:

aws:
  credentials: |-
    [default]
    aws_access_key_id = <some-access-key>
    aws_secret_access_key = <some-secret-key>

This gets rendered as:

|-
  [default]
  aws_access_key_id = <some-access-key>
  aws_secret_access_key = <some-secret-key>

Which is wrong.

Which issue this PR fixes

N/A

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md
  • Title of the PR starts with chart name (e.g. [stable/mychartname])

Signed-off-by: Scott Crooks <scott.crooks@gmail.com>
@helm-bot helm-bot added Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 20, 2020
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 20, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @sc250024. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@zanhsieh
Copy link
Collaborator

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 14, 2020
@sc250024
Copy link
Contributor Author

@zanhsieh Okay to merge this bad boy?

@sarcasticadmin
Copy link
Contributor

I ran into this as well trying to upgrade to 3.11.1, ended up running 3.11.0 for the time being.

Looking forward to getting this merged!

@zanhsieh
Copy link
Collaborator

@sc250024
Sorry, only ids list in the OWNERS file could merge this. My id is not there.

@jkodroff
@callmeradical
@lkysow
@jeff-knurek
@sstarcher
@anubhavmishra
Would you mind to LGTM this PR please?

@zanhsieh
Copy link
Collaborator

/assign @sstarcher

@sstarcher
Copy link
Collaborator

lgtm

@jeff-knurek
Copy link
Collaborator

jeff-knurek commented Apr 24, 2020

/approve


I think the original PR before this should have been a minor version bump (https://semver.org/), but as this is a bug fix within a bug in a patch version, it makes sense as it is now

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 24, 2020
@jeff-knurek
Copy link
Collaborator

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jeff-knurek, sc250024

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 24, 2020
@k8s-ci-robot k8s-ci-robot merged commit 31461bd into helm:master Apr 24, 2020
@sc250024 sc250024 deleted the fix-AtlantisCredentials branch April 24, 2020 09:30
irlevesque pushed a commit to quantopian/charts that referenced this pull request Jul 13, 2020
Signed-off-by: Scott Crooks <scott.crooks@gmail.com>
includerandom pushed a commit to includerandom/helm_charts that referenced this pull request Jul 19, 2020
Signed-off-by: Scott Crooks <scott.crooks@gmail.com>
li-adrienloiseau pushed a commit to li-adrienloiseau/charts that referenced this pull request Jul 29, 2020
Signed-off-by: Scott Crooks <scott.crooks@gmail.com>
Signed-off-by: Adrien Loiseau <adrien.loiseau@logic-immo.com>
mmingorance-dh pushed a commit to mmingorance-dh/charts that referenced this pull request Aug 28, 2020
Signed-off-by: Scott Crooks <scott.crooks@gmail.com>
Signed-off-by: Miguel Mingorance <miguel.mingorance@deliveryhero.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. ok-to-test size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants