Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/grafana] Fix pvc accessModes default value #10116

Closed
wants to merge 1 commit into from
Closed

[stable/grafana] Fix pvc accessModes default value #10116

wants to merge 1 commit into from

Conversation

Dean-Coakley
Copy link
Contributor

@Dean-Coakley Dean-Coakley commented Dec 19, 2018 •
edited
Loading

What this PR does / why we need it:

  • accessMode requires at least one entry to generate a valid configuration. As it currently stands enabling persistence will cause errors until you set accessMode

This PR uncomments the default values as they are only used in the pvc template and resolves the issue.

Which issue this PR fixes

Checklist

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md

@helm-bot helm-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). labels Dec 19, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Dean-Coakley
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: sameersbn

If they are not already assigned, you can assign the PR to them by writing /assign @sameersbn in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@davidkarlsen
Copy link
Member

/ok-to-test

@Dean-Coakley
Copy link
Contributor Author

@davidkarlsen Is this ok to merge? sorry for ping

This was referenced Dec 30, 2018
Closed
Merged
@Dean-Coakley
[stable/grafana] Fix pvc accessModes default value
763a3f0 
* accessModes must have at least one valid entry for any pvc
configuration to be created. This commit sets a reasonable default for
that value.
Signed-off-by: Dean Coakley <dean.s.coakley@gmail.com>
@Dean-Coakley Dean-Coakley force-pushed the fix/pvc-accessMode-default branch from 4f866b3 to 763a3f0 Compare January 9, 2019 00:11
@helm-bot helm-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 9, 2019
@Dean-Coakley
Copy link
Contributor Author

This change has landed in: eb21fab

@Dean-Coakley Dean-Coakley deleted the fix/pvc-accessMode-default branch January 9, 2019 00:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@paskal paskal paskal approved these changes

@foxish foxish Awaiting requested review from foxish

@mattfarina mattfarina Awaiting requested review from mattfarina

Assignees
No one assigned
Labels
Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). ok-to-test size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

stable/grafana persistence.accessModes has a invalid default
5 participants
@Dean-Coakley @k8s-ci-robot @davidkarlsen @paskal @helm-bot