Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/fluentd-elasticsearch] better deprecation info #10354

Merged
merged 1 commit into from
Jan 3, 2019

Conversation

monotek
Copy link
Collaborator

@monotek monotek commented Jan 2, 2019

Signed-off-by: André Bauer monotek23@gmail.com

What this PR does / why we need it:

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

  • fixes #

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md

Signed-off-by: André Bauer <monotek23@gmail.com>
@helm-bot helm-bot added Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 2, 2019
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 2, 2019
@axdotl
Copy link
Contributor

axdotl commented Jan 3, 2019

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: axdotl, monotek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 3, 2019
@k8s-ci-robot k8s-ci-robot merged commit ecd5955 into helm:master Jan 3, 2019
@gajus
Copy link

gajus commented Jan 7, 2019

Whats the reason this chart has been deprecated?

@axdotl
Copy link
Contributor

axdotl commented Jan 7, 2019

@gajus It was moved to https://github.com/kiwigrid/helm-charts and will be maintained there.

Check https://github.com/helm/hub for more details on distributed repos.

@gajus
Copy link

gajus commented Jan 7, 2019

Doesn't answer the question why it was deprecated.

I feel (and I am sure the sentiment is prevalent) a lot more safe by consuming a chart hosted on helm/charts than another repository.

@axdotl
Copy link
Contributor

axdotl commented Jan 7, 2019

There were several discussions about it (see helm/community#24 which results in https://github.com/helm/community/blob/master/proposals/distributed-search.md).

AFAIK this whole repo (at least its content) will become deprecated and as the fluentd-elastisearch chart is no longer maintained here its set deprecated.

wgiddens pushed a commit to wgiddens/charts that referenced this pull request Jan 18, 2019
Signed-off-by: André Bauer <monotek23@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants