This repository has been archived by the owner on Feb 22, 2022. It is now read-only.
Simplify for unifi #10789
Merged
Simplify for unifi #10789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
helm-bot
added
size/L
wernerb
force-pushed
the
unifi-services
branch
from
548eaba to
a1f69fa
Compare
helm-bot
added
size/L
wernerb
force-pushed
the
unifi-services
branch
from
a1f69fa to
373e09d
Compare
helm-bot
added
size/L
wernerb
force-pushed
the
unifi-services
branch
from
373e09d to
b7e214f
Compare
helm-bot
added
size/L
wernerb
force-pushed
the
unifi-services
branch
from
b7e214f to
9b8b83b
Compare
helm-bot
added
size/L
|
This is a very welcome simplification, thank you @wernerb! As the nature of the change isn't backwards-compatible with the current chart, can we please bump the minor semver version? (e.g. to 0.3.0) |
|
Thanks its bumped. |
The discovery and stun ports are part of the same service. Unifi depends on them to be on the same hostname. Signed-off-by: Werner Buck <email@wernerbuck.nl>
wernerb
force-pushed
the
unifi-services
branch
from
9b8b83b to
5e1261a
Compare
helm-bot
added
size/L
|
@wernerb Sorry I didn't address the original question earlier, but agree that a single service for all the things (gui, controller, discovery, stun) makes more sense. Is this something you're willing to include in this PR? |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: billimek, wernerb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
|
This merge breaks my UniFi deployment, please see #11268. |
billimek
added a commit
to billimek/charts-fork
that referenced
this pull request
Feb 8, 2019
This reverts commit df3b21e.
billimek
added a commit
to billimek/charts-fork
that referenced
this pull request
Feb 8, 2019
This reverts commit df3b21e. Signed-off-by: Jeff Billimek <jeff@billimek.com>
tbuchier
pushed a commit
to tbuchier/charts
that referenced
this pull request
Feb 14, 2019
The discovery and stun ports are part of the same service. Unifi depends on them to be on the same hostname. Signed-off-by: Werner Buck <email@wernerbuck.nl>
tbuchier
pushed a commit
to tbuchier/charts
that referenced
this pull request
Feb 14, 2019
* Revert "Simplify for unifi (helm#10789)" This reverts commit df3b21e. Signed-off-by: Jeff Billimek <jeff@billimek.com> * bumping chart version as part of reversion Signed-off-by: Jeff Billimek <jeff@billimek.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This merges the three services into one, letting you have one service (ClusterIP or LoadBalancer, NodePort) that has all ports necessary for proper communication with UAPs.
The problem now is that with each Service you get a different clusterIP (or expensive LoadBalancer) while actually Unifi requires the
8080:/inform,stun, anddiscoveryto be on the same interface. (Same as upstream docker).Unifi can't reach stun port right now because its on a different IP, or with NodePort on a different port. NodePort can still work but its also easier through a single service.
Unifi also has no separate IP binding for these ports meaning they are all expected to run off the same IP.
In fact, if the maintainer allows it, we can also remove the controllerService and move everything in one service with multiple named ports.
Signed-off-by: Werner Buck email@wernerbuck.nl
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]