Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

Atlantis 450 #11246

Merged
merged 2 commits into from
Feb 7, 2019
Merged

Atlantis 450 #11246

merged 2 commits into from
Feb 7, 2019

Conversation

mdaniel
Copy link
Contributor

@mdaniel mdaniel commented Feb 7, 2019

What this PR does / why we need it:

Because Atlantis allows a * to represent a whitelist of all github organizations, if one used --set orgWhitelist='*' then it would insert that value literally into the StatefulSet yaml, causing a parse error

Which issue this PR fixes

fixes: runatlantis/atlantis#450

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md

fixes: runatlantis/atlantis#450

Signed-off-by: Matthew L Daniel <md@stoi.cc>
Signed-off-by: Matthew L Daniel <md@stoi.cc>
@helm-bot helm-bot added Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 7, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @mdaniel. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Feb 7, 2019
@k8s-ci-robot
Copy link
Contributor

@mdaniel: GitHub didn't allow me to assign the following users: jkodroff.

Note that only helm members and repo collaborators can be assigned and that issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @jkodroff

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jkodroff
Copy link
Collaborator

jkodroff commented Feb 7, 2019

/assign @lkysow

@jkodroff
Copy link
Collaborator

jkodroff commented Feb 7, 2019

@mdaniel I'm not a collaborator in this repo. I've submitted #10500 to attempt to rectify this.

@sstarcher
Copy link
Collaborator

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 7, 2019
@lkysow
Copy link
Contributor

lkysow commented Feb 7, 2019

@jkodroff we don't need collaborator. See how I got #11197 merged.

@sstarcher
Copy link
Collaborator

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 7, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mdaniel, sstarcher

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 7, 2019
@k8s-ci-robot k8s-ci-robot merged commit ec89a0c into helm:master Feb 7, 2019
towolf pushed a commit to towolf/charts that referenced this pull request Feb 7, 2019
* Quote the orgWhitelist value in the StatefulSet

fixes: runatlantis/atlantis#450

Signed-off-by: Matthew L Daniel <md@stoi.cc>

* Bump the atlantis chart version

Signed-off-by: Matthew L Daniel <md@stoi.cc>
@mdaniel mdaniel deleted the atlantis-450 branch February 7, 2019 19:36
dbanda pushed a commit to dbanda/charts that referenced this pull request Feb 8, 2019
* Quote the orgWhitelist value in the StatefulSet

fixes: runatlantis/atlantis#450

Signed-off-by: Matthew L Daniel <md@stoi.cc>

* Bump the atlantis chart version

Signed-off-by: Matthew L Daniel <md@stoi.cc>
Signed-off-by: Dalitso Banda <dabanda@microsoft.com>
VRanga000 pushed a commit to VRanga000/charts that referenced this pull request Feb 11, 2019
* Quote the orgWhitelist value in the StatefulSet

fixes: runatlantis/atlantis#450

Signed-off-by: Matthew L Daniel <md@stoi.cc>

* Bump the atlantis chart version

Signed-off-by: Matthew L Daniel <md@stoi.cc>
Signed-off-by: Vikas Rangarajan <vikas_rangarajan@cable.comcast.com>
VRanga000 pushed a commit to VRanga000/charts that referenced this pull request Feb 11, 2019
* Quote the orgWhitelist value in the StatefulSet

fixes: runatlantis/atlantis#450

Signed-off-by: Matthew L Daniel <md@stoi.cc>

* Bump the atlantis chart version

Signed-off-by: Matthew L Daniel <md@stoi.cc>
VRanga000 pushed a commit to VRanga000/charts that referenced this pull request Feb 11, 2019
* Quote the orgWhitelist value in the StatefulSet

fixes: runatlantis/atlantis#450

Signed-off-by: Matthew L Daniel <md@stoi.cc>

* Bump the atlantis chart version

Signed-off-by: Matthew L Daniel <md@stoi.cc>
tbuchier pushed a commit to tbuchier/charts that referenced this pull request Feb 14, 2019
* Quote the orgWhitelist value in the StatefulSet

fixes: runatlantis/atlantis#450

Signed-off-by: Matthew L Daniel <md@stoi.cc>

* Bump the atlantis chart version

Signed-off-by: Matthew L Daniel <md@stoi.cc>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. ok-to-test size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

helm install incorrectly quotes orgWhitelist
6 participants