-
Notifications
You must be signed in to change notification settings - Fork 16.8k
Conversation
fixes: runatlantis/atlantis#450 Signed-off-by: Matthew L Daniel <md@stoi.cc>
Signed-off-by: Matthew L Daniel <md@stoi.cc>
Hi @mdaniel. Thanks for your PR. I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@mdaniel: GitHub didn't allow me to assign the following users: jkodroff. Note that only helm members and repo collaborators can be assigned and that issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @lkysow |
/ok-to-test |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mdaniel, sstarcher The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* Quote the orgWhitelist value in the StatefulSet fixes: runatlantis/atlantis#450 Signed-off-by: Matthew L Daniel <md@stoi.cc> * Bump the atlantis chart version Signed-off-by: Matthew L Daniel <md@stoi.cc>
* Quote the orgWhitelist value in the StatefulSet fixes: runatlantis/atlantis#450 Signed-off-by: Matthew L Daniel <md@stoi.cc> * Bump the atlantis chart version Signed-off-by: Matthew L Daniel <md@stoi.cc> Signed-off-by: Dalitso Banda <dabanda@microsoft.com>
* Quote the orgWhitelist value in the StatefulSet fixes: runatlantis/atlantis#450 Signed-off-by: Matthew L Daniel <md@stoi.cc> * Bump the atlantis chart version Signed-off-by: Matthew L Daniel <md@stoi.cc> Signed-off-by: Vikas Rangarajan <vikas_rangarajan@cable.comcast.com>
* Quote the orgWhitelist value in the StatefulSet fixes: runatlantis/atlantis#450 Signed-off-by: Matthew L Daniel <md@stoi.cc> * Bump the atlantis chart version Signed-off-by: Matthew L Daniel <md@stoi.cc>
* Quote the orgWhitelist value in the StatefulSet fixes: runatlantis/atlantis#450 Signed-off-by: Matthew L Daniel <md@stoi.cc> * Bump the atlantis chart version Signed-off-by: Matthew L Daniel <md@stoi.cc>
* Quote the orgWhitelist value in the StatefulSet fixes: runatlantis/atlantis#450 Signed-off-by: Matthew L Daniel <md@stoi.cc> * Bump the atlantis chart version Signed-off-by: Matthew L Daniel <md@stoi.cc>
What this PR does / why we need it:
Because Atlantis allows a
*
to represent a whitelist of all github organizations, if one used--set orgWhitelist='*'
then it would insert that value literally into the StatefulSet yaml, causing a parse errorWhich issue this PR fixes
fixes: runatlantis/atlantis#450
Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]