This repository has been archived by the owner on Feb 22, 2022. It is now read-only.
Consul - Add consul tests and upgrade consul to 0.8.x #1126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
lachie83
commented
May 18, 2017
lachie83
commented
- Add app version tag
- Update chart maintainers to github username
- Add consul helm tests
- Update documentation
- Remove existing test.sh
Add app version tag Update chart maintainers to github username Add consul helm tests Update documentation Remove existing test.sh
k8s-ci-robot
added
the
cncf-cla: yes
|
cc @foxish hoping to add more testable charts |
This was referenced May 23, 2017
prydonius
previously requested changes
Jun 1, 2017
stable/consul/README.md
Outdated
| @@ -48,13 +47,15 @@ The following tables lists the configurable parameters of the consul chart and t | |||
| | `ui.enabled` | Enable Consul Web UI | `false` | | |||
| | `uiService.enabled` | Create dedicated Consul Web UI svc | `false` | | |||
| | `uiService.type` | Dedicate Consul Web UI svc type | `NodePort` | | |||
| | `test.image` | Test container image requires kubectl + bash (used for helm test) | `lachlanevenson/k8s-kubectl` | | |||
There was a problem hiding this comment.
Yes, I think this is fine. I've documented the prerequisites to cut your own container to run the tests if desired
stable/consul/templates/NOTES.txt
Outdated
| 2. Confirm consul cluster is healthy | ||
| $ kubectl exec {{ .Release.Name }}-consul-0 consul members --namespace={{ .Release.Namespace }} | grep server | ||
| 2. Test cluster health using Helm test. | ||
| $ helm test {{ .Release.Namespace }} |
|
Updated. I think this should be good to go. |
|
@k8s-bot pull-charts-e2e test this |
|
@k8s-bot pull-charts-e2e test this |
|
@prydonius can you please take another pass at this? |
yanns
pushed a commit
to yanns/charts
that referenced
this pull request
Jul 28, 2017
* Bump consul version to 0.8.3 Add app version tag Update chart maintainers to github username Add consul helm tests Update documentation Remove existing test.sh * Update helm test command in notes
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.