Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/velero] Fix s3ForcePathStyle config parsing bug when using minio #11427

Merged
merged 1 commit into from
Feb 19, 2019
Merged

[stable/velero] Fix s3ForcePathStyle config parsing bug when using minio #11427

merged 1 commit into from
Feb 19, 2019
+2 −2

Conversation

gdmello
Copy link
Contributor

@gdmello gdmello commented Feb 14, 2019

What this PR does / why we need it:

Fixes config parsing bug when attempting to deploy velero with minio-

E0214 15:20:18.724270       1 reflector.go:205] github.com/heptio/ark/pkg/generated/informers/externalversions/factory.go:117: 
Failed to list *v1.BackupStorageLocation: v1.BackupStorageLocationList.Items: []
v1.BackupStorageLocation: v1.BackupStorageLocation.Spec: v1.BackupStorageLocationSpec.Config: 
ReadString: expects " or n, but found t, error found in
 #10 byte of ...|thStyle":true,"s3Url|..., bigger context ...|":{"config":
{"region":"minio","s3ForcePathStyle":true,"s3Url":"http://minio.ns-backup.svc.cluster.l|...

Checklist

  • [x ] DCO signed
  • [x ] Chart Version bumped

@gdmello
Fix "ReadString: expects " or n, but found t, error found in helm#10 …
56c6d45 
…byte of ...|thStyle":true,"s3Url|..., bigger context ..."

Signed-off-by: gdmello <gavindmello@gmail.com>
@helm-bot helm-bot added Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 14, 2019
@gdmello
Copy link
Contributor Author

gdmello commented Feb 14, 2019

@domcar / @unguiculus - please review.

@nrb
Copy link
Contributor

nrb commented Feb 14, 2019

LGTM - this is something we've seen people installing with Helm run into, too, so it's nice to have it taken care of for users.

@cpanato
Copy link
Member

cpanato commented Feb 14, 2019

/ok-to-test

@cpanato
Copy link
Member

cpanato commented Feb 19, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 19, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, gdmello

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 19, 2019
@cpanato
Copy link
Member

cpanato commented Feb 19, 2019

/test pull-charts-e2e

1 similar comment
@cpanato
Copy link
Member

cpanato commented Feb 19, 2019

/test pull-charts-e2e

@k8s-ci-robot k8s-ci-robot merged commit 4de9a95 into helm:master Feb 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@prydonius prydonius Awaiting requested review from prydonius

@scottrigby scottrigby Awaiting requested review from scottrigby

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. ok-to-test size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@gdmello @nrb @cpanato @k8s-ci-robot @helm-bot