[stable/external-dns] Add support for Dyn #12166

devcamcar · 2019-03-13T04:13:02Z

What this PR does / why we need it:

Adds support for Dyn to external-dns chart.

Special notes for your reviewer:

Tested against Kubernetes 1.11.5 and Helm 2.13.

Checklist

DCO signed
Chart Version bumped
Variables are documented in the README.md

k8s-ci-robot · 2019-03-13T04:13:16Z

Hi @devcamcar. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

davidkarlsen · 2019-04-21T16:41:43Z

/ok-to-test

stable/external-dns/Chart.yaml

maorfr · 2019-06-27T06:51:46Z

/assign @juan131

juan131 · 2019-06-28T14:38:58Z

Hi @devcamcar I see you and other people requesting adding support for new DNS providers (see #14793)

We're doing a major refactoring of the chart (see #14970) and I'll wait for this change to be approved before adding support for more providers. Once it's accepted I'll come back and review all these PRs. Sorry for the inconveniences.

juan131 · 2019-06-28T14:49:38Z

/hold

juan131 · 2019-07-04T07:58:28Z

/hold cancel
@devcamcar could you please rebase from master and apply the changes on top of the new refactored chart? Thanks in advance

k8s-ci-robot · 2019-07-04T20:02:38Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: devcamcar
To complete the pull request process, please assign juan131
You can assign the PR to them by writing /assign @juan131 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

stable/external-dns/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: Devin Carlen <devin.carlen@gmail.com>

devcamcar · 2019-07-04T20:16:27Z

@juan131 Done, thanks!

juan131

Thanks so much for rebasing and reapplying the changes. Please take a look to my suggestions

juan131 · 2019-07-05T09:50:21Z

stable/external-dns/Chart.yaml

@@ -1,7 +1,7 @@
 apiVersion: v1
 name: external-dns
-version: 2.0.2
-appVersion: 0.5.15
+version: 2.0.3


Please bump minor version instead

juan131 · 2019-07-05T09:51:57Z

stable/external-dns/Chart.yaml

-version: 2.0.2
-appVersion: 0.5.15
+version: 2.0.3
+appVersion: 0.5.16


You don't need to bump the appVersion. Indeed, we haven't release the version 0.5.16 yet, see https://hub.docker.com/r/bitnami/external-dns/tags/

juan131 · 2019-07-05T09:53:18Z

stable/external-dns/templates/secret.yaml

@@ -23,6 +23,15 @@ data:
  {{- if .Values.digitalocean.apiToken }}
  digitalocean_api_token: {{ .Values.digitalocean.apiToken | b64enc | quote }}
  {{- end }}
+  {{ if .Values.dyn.customerName }}


Add {{- to every if statement:

- {{ if .Values.dyn.customerName }} + {{- if .Values.dyn.customerName }}

juan131 · 2019-07-05T09:53:48Z

stable/external-dns/values.yaml

+  customer_name: ""
+  username: ""
+  password: ""
+


Please update the values-production.yaml with the same changes too

juan131 · 2019-07-05T09:54:31Z

stable/external-dns/values.yaml

@@ -120,6 +120,12 @@ digitalocean:
  ##
  apiToken: ""

+# Configuration for Dyn provider.


Please follow the same format for comments:

- # Configuration for Dyn provider. + ## Configuration for Dyn provider. + ##

juan131 · 2019-07-05T09:55:27Z

stable/external-dns/templates/secret.yaml

@@ -1,4 +1,4 @@
-{{- if or .Values.aws.assumeRoleArn (and .Values.aws.credentials.secretKey .Values.aws.credentials.accessKey) .Values.cloudflare.apiKey .Values.digitalocean.apiToken .Values.google.serviceAccountKey (and .Values.infoblox.wapiUsername .Values.infoblox.wapiPassword) .Values.rfc2136.tsigSecret .Values.extraEnv }}
+{{- if or .Values.aws.assumeRoleArn (and .Values.aws.credentials.secretKey .Values.aws.credentials.accessKey) .Values.cloudflare.apiKey .Values.digitalocean.apiToken (and .Values.dyn.customerName .Values.dyn.username .Values.dyn.password) .Values.google.serviceAccountKey (and .Values.infoblox.wapiUsername .Values.infoblox.wapiPassword) .Values.rfc2136.tsigSecret .Values.extraEnv }}


Should it be and or or?

juan131 · 2019-07-05T09:57:12Z

stable/external-dns/templates/deployment.yaml

+              secretKeyRef:
+                name: {{ template "external-dns.fullname" . }}
+                key: dyn_password
+        {{- end }}


Question: are any of these parameters mandatory when provider=dyn?

Yes, all of these fields are required for provider=dyn

juan131 · 2019-07-05T09:57:45Z

stable/external-dns/templates/deployment.yaml

@@ -203,6 +203,28 @@ spec:
              name: {{ template "external-dns.fullname" . }}
              key: digitalocean_api_token
        {{- end }}
+        # Dyn environment variables
+        {{- if .Values.dyn.customerName }}


Add an extra if statement:

{{- if eq .Values.provider "digitalocean" }} ... {{- end }}

juan131 · 2019-08-08T11:39:24Z

Hi @devcamcar !! It seems we forgot about PR, sorry for that
Could you please rebase from master and take a look to my last comments? Thanks

stale · 2019-09-07T12:39:02Z

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions.

stale · 2019-09-21T12:58:37Z

This issue is being automatically closed due to inactivity.

helm-bot added the Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). label Mar 13, 2019

k8s-ci-robot requested a review from scottrigby March 13, 2019 04:13

helm-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 13, 2019

k8s-ci-robot requested a review from unguiculus March 13, 2019 04:13

k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 13, 2019

helm-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 13, 2019

devcamcar force-pushed the master branch from 710474e to f3cf3c7 Compare March 13, 2019 20:35

helm-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 13, 2019

devcamcar force-pushed the master branch from f3cf3c7 to e29c827 Compare April 2, 2019 20:46

devcamcar force-pushed the master branch from e29c827 to 578125d Compare April 20, 2019 01:35

k8s-ci-robot added ok-to-test and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 21, 2019

davidkarlsen suggested changes Apr 21, 2019

View reviewed changes

stable/external-dns/Chart.yaml Outdated Show resolved Hide resolved

devcamcar force-pushed the master branch from 578125d to a55eb4b Compare April 22, 2019 19:48

devcamcar force-pushed the master branch 2 times, most recently from d93edeb to 6a4e4f8 Compare May 5, 2019 19:16

devcamcar force-pushed the master branch 2 times, most recently from 5a78845 to 212d722 Compare May 17, 2019 00:34

devcamcar force-pushed the master branch from 50fe60b to cd4343a Compare June 16, 2019 18:07

k8s-ci-robot assigned juan131 Jun 27, 2019

juan131 mentioned this pull request Jun 28, 2019

[stable/external-dns] Add support for PowerDNS provider #14793

Merged

4 tasks

k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 28, 2019

k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 4, 2019

devcamcar force-pushed the master branch from cd4343a to fee9ecc Compare July 4, 2019 20:02

helm-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 4, 2019

helm-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 4, 2019

[stable/external-dns] Add support for Dyn

3827224

Signed-off-by: Devin Carlen <devin.carlen@gmail.com>

devcamcar force-pushed the master branch from 8a6d854 to 3827224 Compare July 4, 2019 20:15

helm-bot added the Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). label Jul 4, 2019

juan131 suggested changes Jul 5, 2019

View reviewed changes

stale bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 7, 2019

stale bot closed this Sep 21, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[stable/external-dns] Add support for Dyn #12166

[stable/external-dns] Add support for Dyn #12166

devcamcar commented Mar 13, 2019

k8s-ci-robot commented Mar 13, 2019

davidkarlsen commented Apr 21, 2019

maorfr commented Jun 27, 2019

juan131 commented Jun 28, 2019

juan131 commented Jun 28, 2019

juan131 commented Jul 4, 2019

k8s-ci-robot commented Jul 4, 2019

devcamcar commented Jul 4, 2019

juan131 left a comment

juan131 Jul 5, 2019

juan131 Jul 5, 2019

juan131 Jul 5, 2019

juan131 Jul 5, 2019

juan131 Jul 5, 2019

juan131 Jul 5, 2019

juan131 Jul 5, 2019

ivanovaleksandar Jul 22, 2019

juan131 Aug 8, 2019

juan131 Jul 5, 2019

juan131 commented Aug 8, 2019

stale bot commented Sep 7, 2019

stale bot commented Sep 21, 2019

		@@ -1,4 +1,4 @@
		{{- if or .Values.aws.assumeRoleArn (and .Values.aws.credentials.secretKey .Values.aws.credentials.accessKey) .Values.cloudflare.apiKey .Values.digitalocean.apiToken .Values.google.serviceAccountKey (and .Values.infoblox.wapiUsername .Values.infoblox.wapiPassword) .Values.rfc2136.tsigSecret .Values.extraEnv }}
		{{- if or .Values.aws.assumeRoleArn (and .Values.aws.credentials.secretKey .Values.aws.credentials.accessKey) .Values.cloudflare.apiKey .Values.digitalocean.apiToken (and .Values.dyn.customerName .Values.dyn.username .Values.dyn.password) .Values.google.serviceAccountKey (and .Values.infoblox.wapiUsername .Values.infoblox.wapiPassword) .Values.rfc2136.tsigSecret .Values.extraEnv }}

[stable/external-dns] Add support for Dyn #12166

[stable/external-dns] Add support for Dyn #12166

Conversation

devcamcar commented Mar 13, 2019

What this PR does / why we need it:

Special notes for your reviewer:

Checklist

k8s-ci-robot commented Mar 13, 2019

davidkarlsen commented Apr 21, 2019

maorfr commented Jun 27, 2019

juan131 commented Jun 28, 2019

juan131 commented Jun 28, 2019

juan131 commented Jul 4, 2019

k8s-ci-robot commented Jul 4, 2019

devcamcar commented Jul 4, 2019

juan131 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

juan131 commented Aug 8, 2019

stale bot commented Sep 7, 2019

stale bot commented Sep 21, 2019