This repository was archived by the owner on Feb 22, 2022. It is now read-only.
Add ClusterChecks deployment template #12582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
helm-bot
added
the
size/L
|
Hi @clamoriniere. Thanks for your PR. I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
the
needs-ok-to-test
clamoriniere
force-pushed
the
feature/datadog-clusterchecks
branch
from
62e1876 to
e558d75
Compare
helm-bot
added
the
Contribution Allowed
clamoriniere
force-pushed
the
feature/datadog-clusterchecks
branch
6 times, most recently
from
6b81128 to
4b58f10
Compare
clamoriniere
force-pushed
the
feature/datadog-clusterchecks
branch
2 times, most recently
from
bc23bbc to
12e9d2c
Compare
Add the possibility to run dedicated agent(s) for handling the Cluster Checks process. It allows having dedicated `resources` request/limit for the Cluster Checks. Signed-off-by: cedric lamoriniere <cedric.lamoriniere@datadoghq.com>
clamoriniere
force-pushed
the
feature/datadog-clusterchecks
branch
from
12e9d2c to
f0b9346
Compare
|
@xvello, thanks for your review, I updated the PR according to your comments. |
|
/ok-to-test |
k8s-ci-robot
added
ok-to-test
and removed
needs-ok-to-test
Signed-off-by: cedric lamoriniere <cedric.lamoriniere@datadoghq.com>
clamoriniere
force-pushed
the
feature/datadog-clusterchecks
branch
from
cd3edb3 to
c8c2523
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: clamoriniere, xvello The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
crackmac
pushed a commit
to crackmac/charts
that referenced
this pull request
Mar 29, 2019
* Add ClusterChecks deployment template Add the possibility to run dedicated agent(s) for handling the Cluster Checks process. It allows having dedicated `resources` request/limit for the Cluster Checks. Signed-off-by: cedric lamoriniere <cedric.lamoriniere@datadoghq.com> * Some small update Signed-off-by: cedric lamoriniere <cedric.lamoriniere@datadoghq.com>
crackmac
pushed a commit
to crackmac/charts
that referenced
this pull request
Mar 29, 2019
* Add ClusterChecks deployment template Add the possibility to run dedicated agent(s) for handling the Cluster Checks process. It allows having dedicated `resources` request/limit for the Cluster Checks. Signed-off-by: cedric lamoriniere <cedric.lamoriniere@datadoghq.com> * Some small update Signed-off-by: cedric lamoriniere <cedric.lamoriniere@datadoghq.com> Signed-off-by: Kevin Duane <duank001@apps.disney.com>
devnulled
pushed a commit
to devnulled/charts
that referenced
this pull request
Apr 25, 2019
* Add ClusterChecks deployment template Add the possibility to run dedicated agent(s) for handling the Cluster Checks process. It allows having dedicated `resources` request/limit for the Cluster Checks. Signed-off-by: cedric lamoriniere <cedric.lamoriniere@datadoghq.com> * Some small update Signed-off-by: cedric lamoriniere <cedric.lamoriniere@datadoghq.com>
dermorz
pushed a commit
to dermorz/charts
that referenced
this pull request
Apr 26, 2019
* Add ClusterChecks deployment template Add the possibility to run dedicated agent(s) for handling the Cluster Checks process. It allows having dedicated `resources` request/limit for the Cluster Checks. Signed-off-by: cedric lamoriniere <cedric.lamoriniere@datadoghq.com> * Some small update Signed-off-by: cedric lamoriniere <cedric.lamoriniere@datadoghq.com>
goshlanguage
pushed a commit
to goshlanguage/charts
that referenced
this pull request
May 17, 2019
* Add ClusterChecks deployment template Add the possibility to run dedicated agent(s) for handling the Cluster Checks process. It allows having dedicated `resources` request/limit for the Cluster Checks. Signed-off-by: cedric lamoriniere <cedric.lamoriniere@datadoghq.com> * Some small update Signed-off-by: cedric lamoriniere <cedric.lamoriniere@datadoghq.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Add the possibility to run dedicated agent(s) for handling the
Cluster Checks process. It allows having dedicated resources
request/limit for the Cluster Checks.
Which issue this PR fixes
Special notes for your reviewer:
Checklist