-
Notifications
You must be signed in to change notification settings - Fork 16.7k
Make nginx controller container ports configurable #13096
Conversation
Signed-off-by: ChiefAlexander <alex.harder@fishtech.group>
Signed-off-by: ChiefAlexander <alex.harder@fishtech.group>
Hi @ChiefAlexander. Thanks for your PR. I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@mgoodness can you take a look at this please? |
@jackzampolin or @mgoodness Could one of you take a look at this. |
@jackzampolin |
Can I get any 👀 on this? It has almost been a month with no feedback here. @jackzampolin @mgoodness cc: @maorfr you approved the last pr into this chart, any feedback that you can give would be helpful. |
Signed-off-by: ChiefAlexander <alex.harder@fishtech.group>
/assign Very nice and clean. Thanks! |
Signed-off-by: ChiefAlexander <alex.harder@fishtech.group>
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ChiefAlexander, maorfr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* Make nginx controller container ports configurable Signed-off-by: ChiefAlexander <alex.harder@fishtech.group> * Bump chart version Signed-off-by: ChiefAlexander <alex.harder@fishtech.group> * Bump version Signed-off-by: ChiefAlexander <alex.harder@fishtech.group> * bump version Signed-off-by: ChiefAlexander <alex.harder@fishtech.group>
* Make nginx controller container ports configurable Signed-off-by: ChiefAlexander <alex.harder@fishtech.group> * Bump chart version Signed-off-by: ChiefAlexander <alex.harder@fishtech.group> * Bump version Signed-off-by: ChiefAlexander <alex.harder@fishtech.group> * bump version Signed-off-by: ChiefAlexander <alex.harder@fishtech.group>
Signed-off-by: ChiefAlexander alex.harder@fishtech.group
What this PR does / why we need it:
This makes the ports for the nginx-controller container configurable. This was needed to implement kubernetes/ingress-nginx#2724 (comment)
Which issue this PR fixes
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged)Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]