-
Notifications
You must be signed in to change notification settings - Fork 16.7k
[stable/nginx-ingress] Remove need for cluster role in scoped mode #13460
Conversation
Hi @hypnoce. Thanks for your PR. I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@jackzampolin you were suggested as a reviewer :) |
/assign |
Rebased. Thanks ! |
Thanks for the PR. |
You are going to need to bump the version again :) |
…elm#12510) as it is not needed per kubernetes/ingress-nginx#3887. Signed-off-by: Francois JACQUES <fjacques@murex.com>
Done |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ChiefAlexander, hypnoce The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…elm#12510) as it is not needed per kubernetes/ingress-nginx#3887. (helm#13460) Signed-off-by: Francois JACQUES <fjacques@murex.com>
What this PR does / why we need it:
https://github.com/helm/charts/pull/9637/files introduced breaking changes when deploying the chart using a namespace-limited service account.
kubernetes/ingress-nginx#3887 Removed the need to cluster-level access.
This PR reverts #9637
Which issue this PR fixes
Checklist
[stable/chart]