Skip to content
This repository was archived by the owner on Feb 22, 2022. It is now read-only.

[stable/nginx-ingress] Remove need for cluster role in scoped mode #13460

Merged
merged 1 commit into from
May 20, 2019

Conversation

hypnoce
Copy link
Contributor

@hypnoce hypnoce commented May 2, 2019

What this PR does / why we need it:

https://github.com/helm/charts/pull/9637/files introduced breaking changes when deploying the chart using a namespace-limited service account.

kubernetes/ingress-nginx#3887 Removed the need to cluster-level access.
This PR reverts #9637

Which issue this PR fixes

Checklist

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md
  • title of the PR contains starts with chart name e.g. [stable/chart]

@helm-bot helm-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 2, 2019
@k8s-ci-robot k8s-ci-robot requested a review from mgoodness May 2, 2019 10:50
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 2, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @hypnoce. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@helm-bot helm-bot added the Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). label May 2, 2019
@hypnoce
Copy link
Contributor Author

hypnoce commented May 3, 2019

@jackzampolin you were suggested as a reviewer :)

@ChiefAlexander
Copy link
Collaborator

/assign
/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 16, 2019
@hypnoce
Copy link
Contributor Author

hypnoce commented May 20, 2019

Rebased. Thanks !

@ChiefAlexander
Copy link
Collaborator

Thanks for the PR.
/lgtm

@k8s-ci-robot k8s-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 20, 2019
@ChiefAlexander
Copy link
Collaborator

You are going to need to bump the version again :)

…elm#12510) as it is not needed per kubernetes/ingress-nginx#3887.

Signed-off-by: Francois JACQUES <fjacques@murex.com>
@hypnoce
Copy link
Contributor Author

hypnoce commented May 20, 2019

Done

@k8s-ci-robot k8s-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label May 20, 2019
@ChiefAlexander
Copy link
Collaborator

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 20, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ChiefAlexander, hypnoce

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 07ffff0 into helm:master May 20, 2019
eyenx pushed a commit to eyenx/charts that referenced this pull request May 28, 2019
…elm#12510) as it is not needed per kubernetes/ingress-nginx#3887. (helm#13460)

Signed-off-by: Francois JACQUES <fjacques@murex.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. ok-to-test size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
5 participants