Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/prometheus-adapter] Add myself to OWNERS #13887

Merged
merged 1 commit into from
May 21, 2019

Conversation

steven-sheehy
Copy link
Collaborator

What this PR does / why we need it:

There's a lot of open PRs for this chart that aren't being approved. After the call for maintainers, I thought I might offer up my help for this chart. Adds an OWNERS file, adds myself to it and existing chart maintainer from Chart.yaml

Which issue this PR fixes

See #13867

Special notes for your reviewer:

I didn't put my email in the Chart.yaml since I've been getting a lot of spam due to it being in other charts that I maintain. Hope that's OK.

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md
  • title of the PR contains starts with chart name e.g. [stable/chart]

@helm-bot helm-bot added Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 15, 2019
@steven-sheehy
Copy link
Collaborator Author

/assign @maorfr
/assign @MattiasGees

@k8s-ci-robot
Copy link
Contributor

@steven-sheehy: GitHub didn't allow me to assign the following users: mattiasgees.

Note that only helm members and repo collaborators can be assigned and that issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @maorfr
/assign @MattiasGees

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@maorfr
Copy link
Member

maorfr commented May 16, 2019

/cc @MattiasGees
would you like to be added as an OWNER to this chart?

@k8s-ci-robot
Copy link
Contributor

@maorfr: GitHub didn't allow me to request PR reviews from the following users: MattiasGees.

Note that only helm members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @MattiasGees
would you like to be added as an OWNER to this chart?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@maorfr
Copy link
Member

maorfr commented May 21, 2019

/lgtm

welcome @steven-sheehy !

@k8s-ci-robot k8s-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 21, 2019
Signed-off-by: Steven Sheehy <ssheehy@firescope.com>
@steven-sheehy steven-sheehy force-pushed the prometheus-adapter-owners branch from 1c3110e to 1e78209 Compare May 21, 2019 14:08
@k8s-ci-robot k8s-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label May 21, 2019
@steven-sheehy
Copy link
Collaborator Author

@maorfr Mind lgtm it again?

@maorfr
Copy link
Member

maorfr commented May 21, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 21, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maorfr, steven-sheehy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@steven-sheehy
Copy link
Collaborator Author

/retest

@k8s-ci-robot k8s-ci-robot merged commit 7bbead3 into helm:master May 21, 2019
@steven-sheehy steven-sheehy deleted the prometheus-adapter-owners branch May 21, 2019 16:25
eyenx pushed a commit to eyenx/charts that referenced this pull request May 28, 2019
Signed-off-by: Steven Sheehy <ssheehy@firescope.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants