Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/spinnaker] Fix chart not being upgradable #13978

Merged
merged 8 commits into from
Jun 21, 2019
Merged

[stable/spinnaker] Fix chart not being upgradable #13978

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
2ba9f07
[stable/spinnaker] don't include mutable values in spec.volumeClaimTe…
skaji May 20, 2019
b8692fb
[stable/spinnaker] update to 1.10.0
skaji May 20, 2019
50efbac
[stable/spinnaker] define spinnaker.standard-labels-base
skaji May 20, 2019
7b47d86
Merge branch 'master' into fix-spinnaker
skaji May 26, 2019
8347de5
Merge branch 'master' into fix-spinnaker
skaji May 28, 2019
fd0235a
[stable/spinnaker] update to 1.12.0
skaji May 28, 2019
3927c20
Merge branch 'master' into fix-spinnaker
skaji Jun 2, 2019
80a4bb4
Merge branch 'master' into fix-spinnaker
skaji Jun 19, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion stable/spinnaker/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
apiVersion: v1
description: Open source, multi-cloud continuous delivery platform for releasing software changes with high velocity and confidence.
name: spinnaker
version: 1.9.2
version: 1.10.0
appVersion: 1.12.5
home: http://spinnaker.io/
sources:
Expand Down
4 changes: 3 additions & 1 deletion stable/spinnaker/templates/statefulsets/halyard.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,9 @@ spec:
- metadata:
name: halyard-home
labels:
{{ include "spinnaker.standard-labels" . | indent 8 }}
app: {{ include "spinnaker.fullname" . | quote }}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be better to place these values in a helper, then reference it to be something as follows?
{{ include "spinnaker.standard-labels-base" . | indent 8 }}

I know it is another layer of abstraction, but we can use the base labels for other parts of the chart where necessary.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dwardu89 Thanks for your review.
The commit 50efbac defines "spinnaker.standard-labels-base", and use it.

heritage: {{ .Release.Service | quote }}
release: {{ .Release.Name | quote }}
spec:
accessModes: [ "ReadWriteOnce" ]
resources:
Expand Down