Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[incubator/solr] add me as maintainer #14040

Closed
wants to merge 3 commits into from
Closed

[incubator/solr] add me as maintainer #14040

wants to merge 3 commits into from

Conversation

eyenx
Copy link
Contributor

@eyenx eyenx commented May 21, 2019

Based on this list, solr needs some maintainers.

related to: #13869

@helm-bot helm-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 21, 2019
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 21, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @eyenx. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@eyenx
Copy link
Contributor Author

eyenx commented May 21, 2019

/assign @maorfr

@eyenx
add me as maintainer
d54a212 
Signed-off-by: Toni Tauro <toni.tauro@adfinis-sygroup.ch>
@eyenx eyenx force-pushed the solr-add-maintainer branch from c0222e6 to d54a212 Compare May 28, 2019 06:43
@helm-bot helm-bot added the Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). label May 28, 2019
@mattfarina
Copy link
Contributor

cc @ian-thebridge-lucidworks

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: eyenx
To complete the pull request process, please assign maorfr
You can assign the PR to them by writing /assign @maorfr in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@helm-bot helm-bot removed the Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). label Jul 4, 2019
@eyenx
Version bump
c7905ab 
Signed-off-by: Toni Tauro <toni.tauro@adfinis-sygroup.ch>
@eyenx eyenx force-pushed the solr-add-maintainer branch from 3fd116e to c7905ab Compare July 4, 2019 06:21
@helm-bot helm-bot added the Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). label Jul 4, 2019
@maorfr
Copy link
Member

maorfr commented Jul 5, 2019

may you reference us to some previous work you did on this chart? or any others...

in addition, there is no OWNERS file, so this PR will have no effect.

@eyenx
Copy link
Contributor Author

eyenx commented Jul 29, 2019

Just closing this as nobody seems to be interested in merging it.

@eyenx eyenx closed this Jul 29, 2019
@maorfr
Copy link
Member

maorfr commented Jul 29, 2019

did you see my last comment?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@davidkarlsen davidkarlsen Awaiting requested review from davidkarlsen

@mattfarina mattfarina Awaiting requested review from mattfarina

Assignees

@maorfr maorfr

Labels
Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@eyenx @k8s-ci-robot @mattfarina @maorfr @helm-bot