Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/tomcat] add me as maintainer #14041

Closed
wants to merge 1 commit into from
Closed

[stable/tomcat] add me as maintainer #14041

wants to merge 1 commit into from

Conversation

eyenx
Copy link
Contributor

@eyenx eyenx commented May 21, 2019

Based on this list, tomcat needs some maintainers.

related to: #13869

@helm-bot helm-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 21, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: eyenx
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: scottrigby

If they are not already assigned, you can assign the PR to them by writing /assign @scottrigby in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

Hi @eyenx. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 21, 2019
@eyenx
Copy link
Contributor Author

eyenx commented May 21, 2019

/assign @scottrigby

@eyenx
add me as maintainer
7551800 
Signed-off-by: Toni Tauro <toni.tauro@adfinis-sygroup.ch>
@eyenx eyenx force-pushed the tomcat-add-maintainer branch from d2fd3d8 to 7551800 Compare May 28, 2019 06:44
@helm-bot helm-bot added the Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). label May 28, 2019
@stale
Copy link

stale bot commented Jun 27, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions.

@stale stale bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 27, 2019
@eyenx
Copy link
Contributor Author

eyenx commented Jun 27, 2019

bump

@stale stale bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 27, 2019
@stale
Copy link

stale bot commented Jul 27, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions.

@stale stale bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 27, 2019
@eyenx
Copy link
Contributor Author

eyenx commented Jul 29, 2019

Just closing this as nobody seems to be interested in merging it.

@eyenx eyenx closed this Jul 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lachie83 lachie83 Awaiting requested review from lachie83

@viglesiasce viglesiasce Awaiting requested review from viglesiasce

Assignees

@scottrigby scottrigby

Labels
Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@eyenx @k8s-ci-robot @scottrigby @helm-bot