Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/grafana] Fix release namespacing in dashboards-json-configmap.yaml #14425

Closed
wants to merge 2 commits into from
Closed

[stable/grafana] Fix release namespacing in dashboards-json-configmap.yaml #14425

wants to merge 2 commits into from

Conversation

timfpark
Copy link

@timfpark timfpark commented Jun 3, 2019

What this PR does / why we need it:

Commit c90d037#diff-bafa6cfa504816afea02a70a6b35f5be from @lwolf broke the grafana chart for me when it is used with a namespace because .Release.Namespace is not operating off of the correct context and needs a $.Release.Namespace per the rest of the variables in this file.

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

  • fixes #

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped
  • [n/a] Variables are documented in the README.md
  • Title of the PR starts with chart name (e.g. [stable/chart])

@helm-bot helm-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 3, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: timfpark
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: rtluckie

If they are not already assigned, you can assign the PR to them by writing /assign @rtluckie in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 3, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @timfpark. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@steven-sheehy
Copy link
Collaborator

@timfpark Please sign your commits

@maorfr
Copy link
Member

maorfr commented Jun 5, 2019

@steven-sheehy, want to be added as a grafana maintainer? ;)

@maorfr
Copy link
Member

maorfr commented Jun 27, 2019

hey @timfpark,

need to sign the DCO...

@stale
Copy link

stale bot commented Jul 27, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions.

@stale stale bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 27, 2019
@stale
Copy link

stale bot commented Aug 10, 2019

This issue is being automatically closed due to inactivity.

@stale stale bot closed this Aug 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants