-
Notifications
You must be signed in to change notification settings - Fork 16.8k
[stable/grafana] apply comment on last PR #15702
Conversation
Hi @obeyler. Thanks for your PR. I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
I still think that #15149 should be reverted and the connection between dashboardProviders/dashboards and datasources should be just better covered in documentation. |
/assign @zanhsieh |
/ok-to-test |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: davidkarlsen, obeyler The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Olivier Beyler <olivier@MacBook-Pro-de-Olivier.local>
Signed-off-by: Olivier Beyler <olivier@MacBook-Pro-de-Olivier.local>
Signed-off-by: Olivier Beyler <olivier@MacBook-Pro-de-Olivier.local>
What this PR does / why we need it:
apply good remark done on my last PR #15149 by @qrilka and @kieran-brown
see also previous discussion on PR #15544 (closed because git trouble on DCO)
Checklist
[stable/chart]
)