Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/grafana] apply comment on last PR #15702

Merged
merged 1 commit into from
Jul 20, 2019
Merged

[stable/grafana] apply comment on last PR #15702

merged 1 commit into from
Jul 20, 2019

Conversation

obeyler
Copy link
Contributor

@obeyler obeyler commented Jul 18, 2019

What this PR does / why we need it:

apply good remark done on my last PR #15149 by @qrilka and @kieran-brown

see also previous discussion on PR #15544 (closed because git trouble on DCO)

Checklist

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md
  • Title of the PR starts with chart name (e.g. [stable/chart])

Signed-off-by: Olivier Beyler <olivier@MacBook-Pro-de-Olivier.local>
@helm-bot helm-bot added Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 18, 2019
@k8s-ci-robot k8s-ci-robot requested a review from zanhsieh July 18, 2019 19:23
@k8s-ci-robot
Copy link
Contributor

Hi @obeyler. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 18, 2019
@qrilka
Copy link

qrilka commented Jul 18, 2019

I still think that #15149 should be reverted and the connection between dashboardProviders/dashboards and datasources should be just better covered in documentation.

@obeyler
Copy link
Contributor Author

obeyler commented Jul 20, 2019

/assign @zanhsieh

@vsliouniaev
Copy link
Collaborator

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 20, 2019
@davidkarlsen
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 20, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidkarlsen, obeyler

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 20, 2019
@k8s-ci-robot k8s-ci-robot merged commit a616a0e into helm:master Jul 20, 2019
ThoTischner pushed a commit to bitsbeats/charts that referenced this pull request Aug 13, 2019
Signed-off-by: Olivier Beyler <olivier@MacBook-Pro-de-Olivier.local>
kengou pushed a commit to kengou/charts that referenced this pull request Sep 18, 2019
Signed-off-by: Olivier Beyler <olivier@MacBook-Pro-de-Olivier.local>
ramkumarvs pushed a commit to yugabyte/charts-helm-fork that referenced this pull request Sep 30, 2019
Signed-off-by: Olivier Beyler <olivier@MacBook-Pro-de-Olivier.local>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. ok-to-test size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants