Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/superset] Allow to override secret by using existing one #16176

Closed
wants to merge 1 commit into from
Closed

[stable/superset] Allow to override secret by using existing one #16176

wants to merge 1 commit into from

Conversation

link-webcreations
Copy link

What this PR does / why we need it:

This PR will allow to use an existing secret file containg the init_superset.sh and superset_config.py scripts.
This is to allow users to create files/init_superset.sh and files/superset_config.py, and then use the helm templates with a custom secret file to take advantage of Helm templates.
This is not possible using values.yaml directly, because only files within the templates/ folder can.

Which issue this PR fixes

  • none

Special notes for your reviewer:

  • none

Checklist

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md
  • Title of the PR starts with chart name (e.g. [stable/chart])

@helm-bot helm-bot added the Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). label Aug 8, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: link-webcreations
To complete the pull request process, please assign davidkarlsen
You can assign the PR to them by writing /assign @davidkarlsen in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@helm-bot helm-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 8, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @link-webcreations. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 8, 2019
Signed-off-by: Yves ANDOLFATTO <yves.andolfatto@gmail.com>
@helm-bot helm-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 8, 2019
@bigbrozer
Copy link
Contributor

That's something we are waiting for :-) We are using this chart as a dependency and would like to use our own set of secret instead of the proposed default name.

@stale
Copy link

stale bot commented Oct 3, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions.

@stale stale bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 3, 2019
@zanhsieh
Copy link
Collaborator

zanhsieh commented Oct 4, 2019

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 4, 2019
@stale stale bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 4, 2019
@link-webcreations
Copy link
Author

Hello,
Did the tests run as expected ?
Thanks for your feedbacks !
Regards

@zanhsieh
Copy link
Collaborator

@davidkarlsen @scottrigby @jlegrone
Would you guys LGTM this PR please?

@link-webcreations
If this PR passed, would you mind to volunteer as one of this chart owners? Current this chart does not have owner. See:

#13869

@stale
Copy link

stale bot commented Nov 28, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions.

@stale stale bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 28, 2019
@stale
Copy link

stale bot commented Dec 12, 2019

This issue is being automatically closed due to inactivity.

@stale stale bot closed this Dec 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. ok-to-test size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants