-
Notifications
You must be signed in to change notification settings - Fork 16.8k
[stable/superset] Allow to override secret by using existing one #16176
[stable/superset] Allow to override secret by using existing one #16176
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: link-webcreations The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @link-webcreations. Thanks for your PR. I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: Yves ANDOLFATTO <yves.andolfatto@gmail.com>
That's something we are waiting for :-) We are using this chart as a dependency and would like to use our own set of secret instead of the proposed default name. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions. |
/ok-to-test |
Hello, |
@davidkarlsen @scottrigby @jlegrone @link-webcreations |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions. |
This issue is being automatically closed due to inactivity. |
What this PR does / why we need it:
This PR will allow to use an existing secret file containg the
init_superset.sh
andsuperset_config.py
scripts.This is to allow users to create
files/init_superset.sh
andfiles/superset_config.py
, and then use the helm templates with a custom secret file to take advantage of Helm templates.This is not possible using
values.yaml
directly, because only files within thetemplates/
folder can.Which issue this PR fixes
Special notes for your reviewer:
Checklist
[stable/chart]
)