[stable/ambassador] Bump Ambassador Pro version #16700
Conversation
- Ambassador Pro 0.7.0 introduces Ambassador certified builds that require - A license key - Use an image from the quay.io/datawire/ambassador_pro repository - templates/deployment.yaml has been formatted in a backwards compatible way so all Ambassador Pro images before 0.7.0 will still use Ambassador OSS repo. Signed-off-by: Noah Krause <krausenoah@gmail.com>
Signed-off-by: Noah Krause <krausenoah@gmail.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nbkrause The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
helm-bot
added
the
Contribution Allowed
helm-bot
added
the
size/S
k8s-ci-robot
added
approved
|
Hi @nbkrause. Thanks for your PR. I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/ok-to-test |
k8s-ci-robot
added
ok-to-test
and removed
needs-ok-to-test
| @@ -159,7 +174,7 @@ spec: | |||
| {{- toYaml .Values.resources | nindent 12 }} | |||
| {{- if .Values.pro.enabled }} | |||
| - name: ambassador-pro | |||
| image: "{{ .Values.pro.image.repository }}:{{ .Values.pro.image.tag }}" | |||
| image: "{{ .Values.pro.image.repository }}:amb-sidecar-{{ .Values.pro.image.tag }}" | |||
There was a problem hiding this comment.
This would cause breaking changes if you have a copy of the values file with tag: amb-sidecar-0.6.0 as the chart would then generate amb-sidecar-amb-sidecar-0.6.0
There was a problem hiding this comment.
Ughh good point.
I was trying to think of a way to make this backwards compatible since we only bumped the major version a month ago.
I guess I will just have to do that
There was a problem hiding this comment.
I think its fine :) even though I also prefer not bumping majors :D I'm guessing its only for a small subset of users anyway.
| @@ -2,7 +2,7 @@ apiVersion: v1 | |||
| appVersion: 0.76.0 | |||
| description: A Helm chart for Datawire Ambassador | |||
| name: ambassador | |||
| version: 3.3.2 | |||
| version: 3.4.2 | |||
|
Possibly more breaking changes incoming. /hold |
k8s-ci-robot
added
the
do-not-merge/hold
|
@Flydiverny I opened #16904 which includes this change along with a couple of others. I will close this PR upon approval of that one |
What this PR does / why we need it:
Upgrades the version of Ambassador Pro to 0.7.0
Ambassador Pro 0.7.0 introduces Ambassador certified builds which require a license key and to pull the image from the ambassador_pro repository.
This change has been made in a backwards compatible way so Ambassador Pro < 0.7.0 will still use Ambassador OSS repository.
Special notes for your reviewer:
I believe this is backwards compatible but please review the
templates/deployment.yamlfile to make sure I didn't miss a way this is not.Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
[stable/chart])