-
Notifications
You must be signed in to change notification settings - Fork 16.8k
[stable/couchdb] Update to support kube 1.16 changes #17683
Conversation
Signed-off-by: Kevin Lau <kevin.lau31@gmail.com>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: kevinwlau The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @kevinwlau. Thanks for your PR. I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
should this be a major version bump? /ok-to-test |
I'm not sure how to get my gcloud key file into the CircleCI testing environment as a file for use in Line 54 in cc1cfc1
|
I saw a few other PRs that bumped up the minor version for similar changes |
/assign @davidkarlsen is there anything else that needs to be done? |
in light of #18079 I'll migrate this PR to the new chart at https://github.com/apache/couchdb-helm |
Port from helm/charts#17683 Thanks to @kevinqlau for the original PR!
Port from helm/charts#17683 Thanks to @kevinqlau for the original PR!
Port from helm/charts#17683 Co-authored-by: Kevin Lau <kevin.lau31@gmail.com>
Port from helm/charts#17683 Co-authored-by: Kevin Lau <kevin.lau31@gmail.com>
Port from helm/charts#17683 Co-authored-by: Kevin Lau <kevin.lau31@gmail.com>
Port from helm/charts#17683 Co-authored-by: Kevin Lau <kevin.lau31@gmail.com>
Port from helm/charts#17683 Co-authored-by: Kevin Lau <kevin.lau31@gmail.com>
Merged in apache/couchdb-helm#2 |
Is this a new chart
no
What this PR does / why we need it:
Update api versions that have been removed in k8s 1.16
ref: https://kubernetes.io/blog/2019/07/18/api-deprecations-in-1-16/
Which issue this PR fixes
Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
[stable/chart]
)