Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/couchdb] Update to support kube 1.16 changes #17683

Closed
wants to merge 1 commit into from
Closed

[stable/couchdb] Update to support kube 1.16 changes #17683

wants to merge 1 commit into from

Conversation

evie-lau
Copy link

@evie-lau evie-lau commented Oct 3, 2019

Is this a new chart

no

What this PR does / why we need it:

Update api versions that have been removed in k8s 1.16
ref: https://kubernetes.io/blog/2019/07/18/api-deprecations-in-1-16/

Which issue this PR fixes

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped
  • Title of the PR starts with chart name (e.g. [stable/chart])

Signed-off-by: Kevin Lau <kevin.lau31@gmail.com>
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kevinwlau
To complete the pull request process, please assign davidkarlsen
You can assign the PR to them by writing /assign @davidkarlsen in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@helm-bot helm-bot added the Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). label Oct 3, 2019
@helm-bot helm-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 3, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @kevinwlau. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 3, 2019
@evie-lau evie-lau changed the title Update to support kube 1.16 changes [stable/couchdb] Update to support kube 1.16 changes Oct 3, 2019
@maorfr
Copy link
Member

maorfr commented Oct 6, 2019

should this be a major version bump?

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 6, 2019
@evie-lau
Copy link
Author

evie-lau commented Oct 9, 2019

I'm not sure how to get my gcloud key file into the CircleCI testing environment as a file for use in

gcloud auth activate-service-account --key-file <(base64 --decode <<< "$SYNC_CREDS")

@evie-lau
Copy link
Author

evie-lau commented Oct 9, 2019

should this be a major version bump?

I saw a few other PRs that bumped up the minor version for similar changes

@evie-lau
Copy link
Author

/assign @davidkarlsen

is there anything else that needs to be done?

@zanhsieh
Copy link
Collaborator

@kevinwlau
I suggest you slack either @jlegrone and / or @maorfr in kubernetes slack.

If this PR passed, would you consider to be the OWNER of this chart (no OWNER so far)?
#13869

@willholley
Copy link
Contributor

in light of #18079 I'll migrate this PR to the new chart at https://github.com/apache/couchdb-helm

willholley added a commit to apache/couchdb-helm that referenced this pull request Oct 22, 2019
Port from helm/charts#17683

Thanks to @kevinqlau for the original PR!
willholley added a commit to apache/couchdb-helm that referenced this pull request Oct 28, 2019
Port from helm/charts#17683

Thanks to @kevinqlau for the original PR!
willholley added a commit to apache/couchdb-helm that referenced this pull request Oct 31, 2019
Port from helm/charts#17683

Co-authored-by: Kevin Lau <kevin.lau31@gmail.com>
willholley added a commit to apache/couchdb-helm that referenced this pull request Oct 31, 2019
Port from helm/charts#17683

Co-authored-by: Kevin Lau <kevin.lau31@gmail.com>
willholley added a commit to apache/couchdb-helm that referenced this pull request Oct 31, 2019
Port from helm/charts#17683

Co-authored-by: Kevin Lau <kevin.lau31@gmail.com>
willholley added a commit to apache/couchdb-helm that referenced this pull request Oct 31, 2019
Port from helm/charts#17683

Co-authored-by: Kevin Lau <kevin.lau31@gmail.com>
willholley added a commit to apache/couchdb-helm that referenced this pull request Oct 31, 2019
Port from helm/charts#17683

Co-authored-by: Kevin Lau <kevin.lau31@gmail.com>
@evie-lau
Copy link
Author

Merged in apache/couchdb-helm#2

@evie-lau evie-lau closed this Oct 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). ok-to-test size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[stable/couchdb] StatefulSet won't deploy on k8s 1.16
7 participants