Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/hackmd] Support kubernetes >= 1.16 #17716

Merged
merged 1 commit into from
Dec 10, 2019
Merged

[stable/hackmd] Support kubernetes >= 1.16 #17716

merged 1 commit into from
Dec 10, 2019

Conversation

onokatio
Copy link
Contributor

@onokatio onokatio commented Oct 5, 2019

Is this a new chart

No.

What this PR does / why we need it:

stable/hackmd uses extensions/v1beta2and extensions/v1beta1 but kubernetes 1.16 deprecates them.
So this PR migrates charts to use apps/v1.

Which issue this PR fixes

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md
  • Title of the PR starts with chart name (e.g. [stable/chart])

@onokatio
use apps/v1
8c6706d 
Signed-off-by: onokatio <onokatio@gmail.com>
@helm-bot helm-bot added the Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). label Oct 5, 2019
@k8s-ci-robot k8s-ci-robot requested a review from prydonius October 5, 2019 16:34
@helm-bot helm-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 5, 2019
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 5, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @onokatio. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@onokatio
Copy link
Contributor Author

onokatio commented Oct 5, 2019

/assign @paulczar

@zanhsieh
Copy link
Collaborator

zanhsieh commented Oct 5, 2019

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 5, 2019
@onokatio
Copy link
Contributor Author

is it ok to merge?

@zanhsieh
Copy link
Collaborator

@onokatio
You need to get a helm chart member to LGTM this PR in order to merge, since there's no owner for this chart. After helm chart member LGTM this chart, would you volunteer to be an owner of this chart? See:

#13869

@stale
Copy link

stale bot commented Nov 26, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions.

@stale stale bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 26, 2019
@onokatio
Copy link
Contributor Author

@zanhsieh

I'm ok to be a volunteer.

@stale stale bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 27, 2019
@davidkarlsen
Copy link
Member

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidkarlsen, onokatio

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 10, 2019
@k8s-ci-robot k8s-ci-robot merged commit c5722c4 into helm:master Dec 10, 2019
@onokatio onokatio deleted the support-apps-v1 branch December 11, 2019 14:26
@ekeih ekeih mentioned this pull request Dec 13, 2019
Merged
3 tasks
dargolith pushed a commit to dargolith/charts that referenced this pull request Jan 10, 2020
@dargolith
use apps/v1 (helm#17716)
639908e 
Signed-off-by: onokatio <onokatio@gmail.com>
arturrez pushed a commit to arturrez/stable-charts that referenced this pull request Jan 28, 2020
use apps/v1 (helm#17716)
a5f7264 
Signed-off-by: onokatio <onokatio@gmail.com>
Signed-off-by: Artur <artur@upbound.io>
@onokatio onokatio restored the support-apps-v1 branch March 8, 2020 15:20
@onokatio onokatio deleted the support-apps-v1 branch March 8, 2020 15:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@prydonius prydonius Awaiting requested review from prydonius

@viglesiasce viglesiasce Awaiting requested review from viglesiasce

Assignees

@paulczar paulczar

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. ok-to-test size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@onokatio @k8s-ci-robot @zanhsieh @davidkarlsen @paulczar @helm-bot