Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/kiam] Add deprecation notice #17959

Merged
merged 1 commit into from
Nov 27, 2019
Merged

[stable/kiam] Add deprecation notice #17959

merged 1 commit into from
Nov 27, 2019

Conversation

ewbankkit
Copy link
Contributor

What this PR does / why we need it:

Deprecation notice for the kiam chart.
This chart has been deprecated in favour of the uSwitch-hosted Helm chart.

Which issue this PR fixes

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped
  • [ ] Variables are documented in the README.md
  • Title of the PR starts with chart name (e.g. [stable/chart])

@helm-bot helm-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 14, 2019
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 14, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @ewbankkit. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ewbankkit
Copy link
Contributor Author

Related:

@ewbankkit
Add deprecation notice for stable/kiam.
93cf1ea 
Signed-off-by: Kit Ewbank <Kit_Ewbank@hotmail.com>
@helm-bot helm-bot added the Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). label Oct 14, 2019
@ewbankkit
Copy link
Contributor Author

/assign @viglesiasce

@zanhsieh
Copy link
Collaborator

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 15, 2019
@ewbankkit
Copy link
Contributor Author

@viglesiasce Any chance of getting this merged?
Thanks.

scottrigby
scottrigby approved these changes Nov 27, 2019
View reviewed changes
Copy link
Member

@scottrigby scottrigby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 27, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ewbankkit, scottrigby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 27, 2019
@k8s-ci-robot k8s-ci-robot merged commit f32839f into helm:master Nov 27, 2019
@ewbankkit ewbankkit deleted the kiam-deprecation branch November 27, 2019 12:17
crmarques pushed a commit to crmarques/charts that referenced this pull request Nov 29, 2019
@ewbankkit
Add deprecation notice for stable/kiam. (helm#17959)
d1a292b 
Signed-off-by: Kit Ewbank <Kit_Ewbank@hotmail.com>
Signed-off-by: Carlos Roberto Marques Junior <carlos.marques@bndes.gov.br>
hakman pushed a commit to hakman/charts that referenced this pull request Dec 5, 2019
@ewbankkit
Add deprecation notice for stable/kiam. (helm#17959)
60c7ec5 
Signed-off-by: Kit Ewbank <Kit_Ewbank@hotmail.com>
dargolith pushed a commit to dargolith/charts that referenced this pull request Jan 10, 2020
@ewbankkit @dargolith
Add deprecation notice for stable/kiam. (helm#17959)
43b43f0 
Signed-off-by: Kit Ewbank <Kit_Ewbank@hotmail.com>
@scottrigby scottrigby mentioned this pull request Jan 20, 2022
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@scottrigby scottrigby scottrigby approved these changes

@mattfarina mattfarina Awaiting requested review from mattfarina

@unguiculus unguiculus Awaiting requested review from unguiculus

Assignees

@viglesiasce viglesiasce

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. ok-to-test size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[stable/kiam] Migrate chart to uSwitch Helm repository
6 participants
@ewbankkit @k8s-ci-robot @zanhsieh @scottrigby @viglesiasce @helm-bot