Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/distributed-tensorflow] Add Dysproz to OWNERS, update owner in Chart.yml #18164

Merged
merged 2 commits into from
Dec 10, 2019
Merged

[stable/distributed-tensorflow] Add Dysproz to OWNERS, update owner in Chart.yml #18164

merged 2 commits into from
Dec 10, 2019

Conversation

Dysproz
Copy link
Collaborator

@Dysproz Dysproz commented Oct 21, 2019 •
edited
Loading

As discussed with @zanhsieh in PR #16436, I add myself to OWNERS of this chart and update Chart.yml. I've mentioned previous owner in OWNERS file in emeritus section.

This PR is based on issue #13869

Signed-off-by: Szymon krasuski.szymon.piotr@gmail.com

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped (Should it be bumped in this situation?)
  • Variables are documented in the README.md (Owner is not mentioned in README)
  • Title of the PR starts with chart name (e.g. [stable/chart])

@Dysproz
Add Dysproz to OWNERS, update owner in Chart.yml
48d0b5c 
Signed-off-by: Szymon <krasuski.szymon.piotr@gmail.com>
@helm-bot helm-bot added Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 21, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @Dysproz. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. labels Oct 21, 2019
@Dysproz
Bump version
21cac7e 
Signed-off-by: Szymon <krasuski.szymon.piotr@gmail.com>
@Dysproz
Copy link
Collaborator Author

Dysproz commented Oct 21, 2019

/assign @maorfr

@Dysproz
Copy link
Collaborator Author

Dysproz commented Oct 21, 2019

/assign @zanhsieh

@Dysproz
Copy link
Collaborator Author

Dysproz commented Oct 21, 2019

/assign @lachie83

@Dysproz
Copy link
Collaborator Author

Dysproz commented Oct 21, 2019

@maorfr @lachie83
Would you mind granting me as one of the owners of this chart?

@maorfr
Copy link
Member

maorfr commented Oct 28, 2019

@cheyang ptal

@zanhsieh
Copy link
Collaborator

@Dysproz
Check your email if invitation received.

@Dysproz
Copy link
Collaborator Author

Dysproz commented Oct 28, 2019

@zanhsieh
I didn't receive any invitation

@zanhsieh
Copy link
Collaborator

@maorfr
Would you mind to take a look please? Thank you.
/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 28, 2019
@maorfr
Copy link
Member

maorfr commented Nov 5, 2019

i would like to wait for @cheyang to respond

@Dysproz
Copy link
Collaborator Author

Dysproz commented Dec 4, 2019

@maorfr After a month of waiting, can we proceed further or are we still waiting?

@maorfr
Copy link
Member

maorfr commented Dec 10, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 10, 2019
@Dysproz
Copy link
Collaborator Author

Dysproz commented Dec 10, 2019

/retest

@Dysproz
Copy link
Collaborator Author

Dysproz commented Dec 10, 2019

/verify-owners

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Dec 10, 2019
@Dysproz
Copy link
Collaborator Author

Dysproz commented Dec 10, 2019

/lgtm

@k8s-ci-robot
Copy link
Contributor

@Dysproz: you cannot LGTM your own PR.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Dysproz, maorfr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit be8ab92 into helm:master Dec 10, 2019
dargolith pushed a commit to dargolith/charts that referenced this pull request Jan 10, 2020
@Dysproz @dargolith
[stable/distributed-tensorflow] Add Dysproz to OWNERS, update owner i…
89d8a26 
…n Chart.yml (helm#18164)

* Add Dysproz to OWNERS, update owner in Chart.yml

Signed-off-by: Szymon <krasuski.szymon.piotr@gmail.com>

* Bump version

Signed-off-by: Szymon <krasuski.szymon.piotr@gmail.com>
arturrez pushed a commit to arturrez/stable-charts that referenced this pull request Jan 28, 2020
@Dysproz
[stable/distributed-tensorflow] Add Dysproz to OWNERS, update owner i…
941cf07 
…n Chart.yml (helm#18164)

* Add Dysproz to OWNERS, update owner in Chart.yml

Signed-off-by: Szymon <krasuski.szymon.piotr@gmail.com>

* Bump version

Signed-off-by: Szymon <krasuski.szymon.piotr@gmail.com>
Signed-off-by: Artur <artur@upbound.io>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@paulczar paulczar Awaiting requested review from paulczar

@unguiculus unguiculus Awaiting requested review from unguiculus

Assignees

@zanhsieh zanhsieh

@lachie83 lachie83

@maorfr maorfr

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. ok-to-test size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Dysproz @k8s-ci-robot @maorfr @zanhsieh @lachie83 @helm-bot