Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/stolon] Add OWNERS file #18175

Merged
merged 4 commits into from
Dec 1, 2019
Merged

[stable/stolon] Add OWNERS file #18175

merged 4 commits into from
Dec 1, 2019

Conversation

lwolf
Copy link
Collaborator

@lwolf lwolf commented Oct 22, 2019

What this PR does / why we need it:

This PR adds OWNERS file to the stable/stolon chart

Which issue this PR fixes

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Title of the PR starts with chart name (e.g. [stable/chart])

@helm-bot helm-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 22, 2019
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 22, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @lwolf. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Oct 22, 2019
@lwolf lwolf mentioned this pull request Oct 22, 2019
Closed
3 tasks
@lwolf
Copy link
Collaborator Author

lwolf commented Oct 22, 2019

/assign @mattfarina

@zanhsieh
Copy link
Collaborator

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 22, 2019
zanhsieh
zanhsieh reviewed Oct 22, 2019
View reviewed changes
Copy link
Collaborator

@zanhsieh zanhsieh left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lwof Chart version bump still needed

@lwolf
Copy link
Collaborator Author

lwolf commented Oct 22, 2019

@zanhsieh bumped the version

@lwolf
Copy link
Collaborator Author

lwolf commented Oct 22, 2019 •
edited
Loading

do I or somebody need to do something about this

The following users are mentioned in OWNERS file(s) but are not members of the helm org.

Once all users have been added as members of the org, you can trigger verification by writing /verify-owners in a comment.

@zanhsieh
Copy link
Collaborator

@lwolf
I think you still have couple commits required signing DCO. After done, let's get helm member to LGTM this.

@helm-bot helm-bot added the Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). label Oct 23, 2019
@lwolf
Copy link
Collaborator Author

lwolf commented Oct 23, 2019

thanks @zanhsieh
I've fixed the DCO

@zanhsieh
Copy link
Collaborator

@davidkarlsen @maorfr
Would you guys LGTM this please? Thank you.

@maorfr
Copy link
Member

maorfr commented Nov 5, 2019

/lgtm

invited both @lwolf and @rtluckie to join as trusted collaborators. accept the invitation and comment /verify-owners.

@k8s-ci-robot k8s-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 5, 2019
@maorfr maorfr mentioned this pull request Nov 5, 2019
Closed
3 tasks
@lwolf
Copy link
Collaborator Author

lwolf commented Nov 5, 2019

/verify-owners

@scottrigby
Copy link
Member

/verify-owners

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Nov 27, 2019
scottrigby
scottrigby approved these changes Nov 27, 2019
View reviewed changes
Copy link
Member

@scottrigby scottrigby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

lwolf added 2 commits November 29, 2019 17:22
@lwolf
[stable/stolon] Add OWNERS file
c74c501 
Signed-off-by: Sergey Nuzhdin <ipaq.lw@gmail.com>
@lwolf
[stable/stolon] bump version
4b3bbb3 
Signed-off-by: Sergey Nuzhdin <ipaq.lw@gmail.com>
@k8s-ci-robot k8s-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Nov 29, 2019
@helm-bot helm-bot removed the Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). label Nov 29, 2019
@lwolf
[stable/stolon] bump version
b2aca93 
Signed-off-by: Sergey Nuzhdin <ipaq.lw@gmail.com>
@helm-bot helm-bot added the Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). label Nov 29, 2019
@lwolf
Copy link
Collaborator Author

lwolf commented Nov 29, 2019

/retest

@davidkarlsen
Copy link
Member

/lgtm
/assign

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 1, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidkarlsen, lwolf, maorfr, scottrigby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [davidkarlsen,maorfr,scottrigby]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 5f9f3c2 into helm:master Dec 1, 2019
hakman pushed a commit to hakman/charts that referenced this pull request Dec 5, 2019
@lwolf
[stable/stolon] Add OWNERS file (helm#18175)
44cf2d3 
* [stable/stolon] Add OWNERS file

Signed-off-by: Sergey Nuzhdin <ipaq.lw@gmail.com>

* [stable/stolon] bump version

Signed-off-by: Sergey Nuzhdin <ipaq.lw@gmail.com>

* [stable/stolon] bump version

Signed-off-by: Sergey Nuzhdin <ipaq.lw@gmail.com>
dargolith pushed a commit to dargolith/charts that referenced this pull request Jan 10, 2020
@lwolf @dargolith
[stable/stolon] Add OWNERS file (helm#18175)
69282a5 
* [stable/stolon] Add OWNERS file

Signed-off-by: Sergey Nuzhdin <ipaq.lw@gmail.com>

* [stable/stolon] bump version

Signed-off-by: Sergey Nuzhdin <ipaq.lw@gmail.com>

* [stable/stolon] bump version

Signed-off-by: Sergey Nuzhdin <ipaq.lw@gmail.com>
arturrez pushed a commit to arturrez/stable-charts that referenced this pull request Jan 28, 2020
@lwolf
[stable/stolon] Add OWNERS file (helm#18175)
9862afa 
* [stable/stolon] Add OWNERS file

Signed-off-by: Sergey Nuzhdin <ipaq.lw@gmail.com>

* [stable/stolon] bump version

Signed-off-by: Sergey Nuzhdin <ipaq.lw@gmail.com>

* [stable/stolon] bump version

Signed-off-by: Sergey Nuzhdin <ipaq.lw@gmail.com>
Signed-off-by: Artur <artur@upbound.io>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zanhsieh zanhsieh zanhsieh left review comments

@merqurio merqurio merqurio approved these changes

@scottrigby scottrigby scottrigby approved these changes

@davidkarlsen davidkarlsen Awaiting requested review from davidkarlsen

@unguiculus unguiculus Awaiting requested review from unguiculus

Assignees

@davidkarlsen davidkarlsen

@mattfarina mattfarina

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. ok-to-test size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Call for maintainers for charts with no OWNERS
9 participants
@lwolf @k8s-ci-robot @zanhsieh @maorfr @scottrigby @davidkarlsen @merqurio @mattfarina @helm-bot