Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/kured] Change psp apiVersion for K8s 1.16 #18373

Merged
merged 1 commit into from
Nov 6, 2019
Merged

[stable/kured] Change psp apiVersion for K8s 1.16 #18373

merged 1 commit into from
Nov 6, 2019

Conversation

ckotzbauer
Copy link
Contributor

What this PR does / why we need it:

Ensure compatibility with K8s 1.16 and therefore use new apiVersion for PodSecurityPolicy.

Which issue this PR fixes

No issue

Special notes for your reviewer:

Nothing special

Checklist

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md
  • Title of the PR starts with chart name (e.g. [stable/mychartname])

@helm-bot helm-bot added Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 26, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @code-chris. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 26, 2019
@ckotzbauer
Copy link
Contributor Author

/assign @maorfr
ping @plumdog @patrickmslatteryvt

@plumdog
Copy link
Contributor

plumdog commented Oct 26, 2019

Does this change the effective minimum k8s version?

@ckotzbauer
Copy link
Contributor Author

@plumdog
Yes, it does. The new apiVersion requires K8s 1.10 or higher. The current min version of this chart is at least 1.9 (apps/v1 in DaemonSet), but I'm not completely sure.

@zanhsieh
Copy link
Collaborator

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 26, 2019
@ckotzbauer
Copy link
Contributor Author

@plumdog @zanhsieh
Is there anything to do here to get this merged?

@zanhsieh
Copy link
Collaborator

zanhsieh commented Nov 2, 2019

@code-chris
You need a helm member to merge this PR, since it doesn't have any owner.

@maorfr @jlegrone
Would you mind to LGTM this PR please? Thank you.

@maorfr
Copy link
Member

maorfr commented Nov 5, 2019

i would prefer to have backwards compatibility. #17268 has an example. wdyt?

@ckotzbauer
Copy link
Contributor Author

Yes, I can implement this switch. No problem

@helm-bot helm-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 5, 2019
Signed-off-by: Christian Kotzbauer <christian.kotzbauer@gmail.com>
@ckotzbauer
Copy link
Contributor Author

Added a switch for PSP apiVersion to be compatible with older versions.
Maybe the min required version (I think 1.9) should be documented in the README with an additional PR.

@maorfr
Copy link
Member

maorfr commented Nov 6, 2019

/lgtm

thanks a lot!

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 6, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: code-chris, maorfr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 6, 2019
@k8s-ci-robot k8s-ci-robot merged commit 28b6c0a into helm:master Nov 6, 2019
@ckotzbauer ckotzbauer deleted the kured-1.16 branch November 6, 2019 06:35
JoseAlban pushed a commit to JoseAlban/charts that referenced this pull request Nov 22, 2019
Signed-off-by: Christian Kotzbauer <christian.kotzbauer@gmail.com>
hakman pushed a commit to hakman/charts that referenced this pull request Dec 5, 2019
Signed-off-by: Christian Kotzbauer <christian.kotzbauer@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. ok-to-test size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants