-
Notifications
You must be signed in to change notification settings - Fork 16.8k
[stable/kured] Change psp apiVersion for K8s 1.16 #18373
Conversation
Hi @code-chris. Thanks for your PR. I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @maorfr |
Does this change the effective minimum k8s version? |
@plumdog |
/ok-to-test |
@code-chris @maorfr @jlegrone |
i would prefer to have backwards compatibility. #17268 has an example. wdyt? |
Yes, I can implement this switch. No problem |
Signed-off-by: Christian Kotzbauer <christian.kotzbauer@gmail.com>
Added a switch for PSP apiVersion to be compatible with older versions. |
/lgtm thanks a lot! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: code-chris, maorfr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Christian Kotzbauer <christian.kotzbauer@gmail.com>
Signed-off-by: Christian Kotzbauer <christian.kotzbauer@gmail.com>
What this PR does / why we need it:
Ensure compatibility with K8s 1.16 and therefore use new apiVersion for PodSecurityPolicy.
Which issue this PR fixes
No issue
Special notes for your reviewer:
Nothing special
Checklist
[stable/mychartname]
)