Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/fluentd] Remove duplicate pvc resource (#19131) #19133

Merged
merged 1 commit into from
Dec 6, 2019
Merged

[stable/fluentd] Remove duplicate pvc resource (#19131) #19133

merged 1 commit into from
Dec 6, 2019

Conversation

Uvedale
Copy link
Contributor

@Uvedale Uvedale commented Nov 25, 2019

What this PR does / why we need it:

This fixes a bug that prevents the installation of the chart with persistence enabled and autoscaling disabled.

Which issue this PR fixes

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md
  • Title of the PR starts with chart name (e.g. [stable/mychartname])

@helm-bot helm-bot added the Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). label Nov 25, 2019
@helm-bot helm-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 25, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @Uvedale. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 25, 2019
@Uvedale
Copy link
Contributor Author

Uvedale commented Nov 25, 2019

/assign @Miouge1

@Miouge1
Copy link
Collaborator

Miouge1 commented Dec 5, 2019

Looks good, @Uvedale can you rebase on latest master?

@Uvedale
[stable/fluentd] Remove duplicate pvc resource (helm#19131)
29eed4e 
Signed-off-by: Dale Tristram <dale.tristram@sprinthive.com>
@Uvedale
Copy link
Contributor Author

Uvedale commented Dec 5, 2019

@Miouge1 done

@Miouge1
Copy link
Collaborator

Miouge1 commented Dec 6, 2019

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 6, 2019
@Miouge1
Copy link
Collaborator

Miouge1 commented Dec 6, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 6, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Miouge1, Uvedale

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 6, 2019
@k8s-ci-robot k8s-ci-robot merged commit 49b2a46 into helm:master Dec 6, 2019
WyriHaximus pushed a commit to WyriHaximus-labs/charts that referenced this pull request Dec 14, 2019
@Uvedale @WyriHaximus
[stable/fluentd] Remove duplicate pvc resource (helm#19131) (helm#19133)
00a382d 
Signed-off-by: Dale Tristram <dale.tristram@sprinthive.com>
dargolith pushed a commit to dargolith/charts that referenced this pull request Jan 10, 2020
@Uvedale @dargolith
[stable/fluentd] Remove duplicate pvc resource (helm#19131) (helm#19133)
8769d31 
Signed-off-by: Dale Tristram <dale.tristram@sprinthive.com>
arturrez pushed a commit to arturrez/stable-charts that referenced this pull request Jan 28, 2020
@Uvedale
[stable/fluentd] Remove duplicate pvc resource (helm#19131) (helm#19133)
ccb27fc 
Signed-off-by: Dale Tristram <dale.tristram@sprinthive.com>
Signed-off-by: Artur <artur@upbound.io>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hectorj2f hectorj2f Awaiting requested review from hectorj2f

@rendhalver rendhalver Awaiting requested review from rendhalver

Assignees

@Miouge1 Miouge1

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. ok-to-test size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[stable/fluentd] Duplicate PVC resource
4 participants
@Uvedale @k8s-ci-robot @Miouge1 @helm-bot