Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/openldap] Fix for "spec.clusterIP: Invalid value" error on upgrade #19428

Closed
wants to merge 1 commit into from
Closed

[stable/openldap] Fix for "spec.clusterIP: Invalid value" error on upgrade #19428

wants to merge 1 commit into from

Conversation

Jyrno42
Copy link
Contributor

@Jyrno42 Jyrno42 commented Dec 6, 2019

What this PR does / why we need it:

Ensures users can upgrade existing installs

see

Checklist

  • DCO signed
  • Chart Version bumped
  • Title of the PR starts with chart name (e.g. [stable/mychartname])

@helm-bot helm-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 6, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Jyrno42
To complete the pull request process, please assign jlegrone
You can assign the PR to them by writing /assign @jlegrone in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

Hi @Jyrno42. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Dec 6, 2019
@Jyrno42 Jyrno42 changed the title [stable/openldap] Fix for "spec.clusterIP: Invalid value" error on upgrade WIP: [stable/openldap] Fix for "spec.clusterIP: Invalid value" error on upgrade Dec 6, 2019
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 6, 2019
@Jyrno42 Jyrno42 force-pushed the openldap-avoid-bad-quotes branch from c1edd99 to f73fd3b Compare December 6, 2019 12:33
@helm-bot helm-bot added the Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). label Dec 6, 2019
@Jyrno42 Jyrno42 force-pushed the openldap-avoid-bad-quotes branch 3 times, most recently from 73c61fc to 5638874 Compare December 10, 2019 14:34
@Jyrno42
[stable/openldap] Fix for "spec.clusterIP: Invalid value" error on up…
bf3582b 
…grade

see

- helm#13646

Signed-off-by: Jyrno Ader <jyrno42@gmail.com>
@Jyrno42 Jyrno42 force-pushed the openldap-avoid-bad-quotes branch from 5638874 to bf3582b Compare December 10, 2019 14:52
@Jyrno42 Jyrno42 changed the title WIP: [stable/openldap] Fix for "spec.clusterIP: Invalid value" error on upgrade [stable/openldap] Fix for "spec.clusterIP: Invalid value" error on upgrade Dec 10, 2019
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 10, 2019
@Jyrno42
Copy link
Contributor Author

Jyrno42 commented Jan 2, 2020

/assign @jlegrone

@zanhsieh
Copy link
Collaborator

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 11, 2020
@rpocase
Copy link

rpocase commented Jan 22, 2020

Any ETA on this getting merged @viglesiasce @unguiculus ?

@stale
Copy link

stale bot commented Feb 21, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions.

@stale stale bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 21, 2020
@rpocase rpocase mentioned this pull request Feb 21, 2020
Merged
4 tasks
@stale
Copy link

stale bot commented Mar 6, 2020

This issue is being automatically closed due to inactivity.

@stale stale bot closed this Mar 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@unguiculus unguiculus Awaiting requested review from unguiculus

@viglesiasce viglesiasce Awaiting requested review from viglesiasce

Assignees

@jlegrone jlegrone

Labels
Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. ok-to-test size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Jyrno42 @k8s-ci-robot @zanhsieh @rpocase @jlegrone @helm-bot