Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

stable/sonarqube templates/deployment.yaml initContainers.image value override #19950

Closed
wants to merge 1 commit into from

Conversation

bhood4
Copy link

@bhood4 bhood4 commented Jan 8, 2020

initContainers.image: {{ default "busybox:1.31" .Values.plugins.initSysctlContainerImage }}

Is this a new chart

NOTE: We're experiencing a high volume of PRs to this repo and reviews will be delayed. Please host your own chart repository and submit your repository to the Helm Hub instead of this repo to make them discoverable to the community. Here is how to submit new chart repositories to the Helm Hub.

What this PR does / why we need it:

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

  • fixes #

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md
  • Title of the PR starts with chart name (e.g. [stable/mychartname])

initContainers.image: {{ default "busybox:1.31" .Values.plugins.initSysctlContainerImage }}
@helm-bot helm-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 8, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @bhood4. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 8, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bhood4
To complete the pull request process, please assign rjkernick
You can assign the PR to them by writing /assign @rjkernick in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@bhood4 bhood4 changed the title initContainers.image value override stable/sonarqube/templates deployment.yaml initContainers.image value override Jan 8, 2020
@bhood4 bhood4 changed the title stable/sonarqube/templates deployment.yaml initContainers.image value override stable/sonarqube templates/deployment.yaml initContainers.image value override Jan 8, 2020
@rjkernick
Copy link
Collaborator

A couple of changes needed before this can be merged:

  1. Commits need signed: https://github.com/helm/charts/pull/19950/checks?check_run_id=380011600
  2. The version in chart.yaml needs incremented
  3. The new override needs to be included in values.yaml and the readme so people can find it easy

@rjkernick
Copy link
Collaborator

/assign

@stale
Copy link

stale bot commented Feb 12, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions.

@stale stale bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 12, 2020
@davidkarlsen
Copy link
Member

This chart has been deprecated and moved: #21007

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants