Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/mariadb] Use storageClassName for mariadb. #2004

Merged
merged 1 commit into from
Sep 7, 2017

Conversation

gyliu513
Copy link
Contributor

@gyliu513 gyliu513 commented Sep 6, 2017

Fixed mariadb for #1869

/cc @prydonius

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 6, 2017
@scottrigby
Copy link
Member

In the charts meeting we said there's no reason this can't be merged. I had a question about the need for the - abstraction, but we agreed I'll open a separate discussion issue about the differences in go template between nil and "" (empty string), and if it turns out we can easily detect the difference between the two, I could open a refactoring PR for this. 👍

@mgoodness
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 7, 2017
@mgoodness mgoodness merged commit aa0380f into helm:master Sep 7, 2017
@gyliu513 gyliu513 deleted the mariadb branch September 8, 2017 01:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants