Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

deprecate wavefront #20055

Merged
merged 2 commits into from
Jan 20, 2020
Merged

deprecate wavefront #20055

merged 2 commits into from
Jan 20, 2020

Conversation

puckpuck
Copy link
Contributor

What this PR does / why we need it:

Deprecating Wavefront chart in favor of new repo

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md
  • Title of the PR starts with chart name (e.g. [stable/mychartname])

@puckpuck
deprecate wavefront
268ab9d 
Signed-off-by: Pierre Tessier <pierre@pierretessier.com>
@helm-bot helm-bot added Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 11, 2020
@k8s-ci-robot k8s-ci-robot requested a review from cpanato January 11, 2020 00:38
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 11, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @puckpuck. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@puckpuck
fix yaml lint
fc0b8bd 
Signed-off-by: Pierre Tessier <pierre@pierretessier.com>
@zanhsieh
Copy link
Collaborator

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 18, 2020
@vikramraman
Copy link

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: puckpuck, vikramraman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 20, 2020
@k8s-ci-robot k8s-ci-robot merged commit 61ac2f6 into helm:master Jan 20, 2020
@puckpuck puckpuck deleted the wavefront branch January 20, 2020 18:52
arturrez pushed a commit to arturrez/stable-charts that referenced this pull request Jan 28, 2020
@puckpuck @k8s-ci-robot
deprecate wavefront (helm#20055)
03dc91e 
* deprecate wavefront

Signed-off-by: Pierre Tessier <pierre@pierretessier.com>

* fix yaml lint

Signed-off-by: Pierre Tessier <pierre@pierretessier.com>
Signed-off-by: Artur <artur@upbound.io>
arturrez pushed a commit to arturrez/stable-charts that referenced this pull request Jan 28, 2020
@puckpuck
deprecate wavefront (helm#20055)
4251bd8 
* deprecate wavefront

Signed-off-by: Pierre Tessier <pierre@pierretessier.com>

* fix yaml lint

Signed-off-by: Pierre Tessier <pierre@pierretessier.com>
Signed-off-by: Artur <artur@upbound.io>
@scottrigby scottrigby mentioned this pull request Jan 20, 2022
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cpanato cpanato Awaiting requested review from cpanato

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. ok-to-test size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@puckpuck @k8s-ci-robot @zanhsieh @vikramraman @helm-bot