[stable/influxdb] Adds missing headless service configuration. #20237

hydra-bu · 2020-01-20T04:50:27Z

Other modifications:

add release label to statefulset.yaml.
modify annotations syntax in values.yaml.

Signed-off-by: spring-bu bushengquan@gmail.com

Is this a new chart

NOTE: We're experiencing a high volume of PRs to this repo and reviews will be delayed. Please host your own chart repository and submit your repository to the Helm Hub instead of this repo to make them discoverable to the community. Here is how to submit new chart repositories to the Helm Hub.

What this PR does / why we need it:

https://kubernetes.io/docs/concepts/workloads/controllers/statefulset/#limitations

StatefulSets currently require a Headless Service to be responsible for the network identity of the Pods. You are responsible for creating this Service.

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

fixes [stable/influxdb] Missing headless service configuration. #20204

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

DCO signed
Chart Version bumped
Variables are documented in the README.md
Title of the PR starts with chart name (e.g. [stable/mychartname])

Other modifications: 1. add release label to statefulset.yaml. 2. modify annotations syntax in values.yaml. Signed-off-by: spring-bu <bushengquan@gmail.com>

k8s-ci-robot · 2020-01-20T04:50:29Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: spring-bu
To complete the pull request process, please assign jackzampolin
You can assign the PR to them by writing /assign @jackzampolin in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

stable/influxdb/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot · 2020-01-20T04:50:42Z

Hi @spring-bu. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

naseemkullah · 2020-02-15T05:52:32Z

stable/influxdb/Chart.yaml

@@ -1,6 +1,6 @@
 apiVersion: v1
 name: influxdb
-version: 3.2.0
+version: 3.2.1


Suggested change

version: 3.2.1

version: 4.0.2

naseemkullah · 2020-02-15T05:53:34Z

stable/influxdb/templates/service-headless.yaml

+  app: {{ template "influxdb.fullname" . }}
+  chart: {{ template "influxdb.chart" . }}
+  release: {{ .Release.Name }}
+  heritage: {{ .Release.Service }}


We've updated labels since 4.0.0 you can use:

metadata: name: {{ include "influxdb.fullname" . }} labels: {{- include "influxdb.labels" . | nindent 4 }}

naseemkullah · 2020-02-15T05:55:11Z

stable/influxdb/templates/service-headless.yaml

+      targetPort: {{ .Values.config.rpc.bind_address }}
+    {{- end }}
+  selector:
+      app: {{ template "influxdb.fullname" . }}


Suggested change

app: {{ template "influxdb.fullname" . }}

{{- include "influxdb.selectorLabels" . | nindent 4 }}

naseemkullah · 2020-02-15T05:55:25Z

stable/influxdb/templates/service-headless.yaml

+    {{- end }}
+  selector:
+      app: {{ template "influxdb.fullname" . }}
+      release: "{{ .Release.Name }}"


Suggested change

release: "{{ .Release.Name }}"

naseemkullah · 2020-02-15T05:56:11Z

stable/influxdb/templates/statefulset.yaml

@@ -139,6 +139,10 @@ spec:
  volumeClaimTemplates:
    - metadata:


You could use:

metadata: name: {{ include "influxdb.fullname" . }}-data labels: {{- include "influxdb.labels" . | nindent 4 }}

naseemkullah · 2020-02-15T05:58:32Z

stable/influxdb/templates/service-headless.yaml

@@ -0,0 +1,50 @@
+apiversion: v1
+kind: Service
+metadata:


With label helpers added in 4.0.0 of the chart, you can now do something like:

metadata: name: {{ include "influxdb.fullname" . }}-headless labels: {{- include "influxdb.labels" . | nindent 4 }}

naseemkullah · 2020-02-15T05:58:56Z

stable/influxdb/templates/service-headless.yaml

+      targetPort: {{ .Values.config.rpc.bind_address }}
+    {{- end }}
+  selector:
+      app: {{ template "influxdb.fullname" . }}


Suggested change

app: {{ template "influxdb.fullname" . }}

{{- include "influxdb.selectorLabels" . | nindent 4 }}

naseemkullah · 2020-02-15T05:59:08Z

stable/influxdb/templates/service-headless.yaml

+    {{- end }}
+  selector:
+      app: {{ template "influxdb.fullname" . }}
+      release: "{{ .Release.Name }}"


Suggested change

release: "{{ .Release.Name }}"

naseemkullah · 2020-02-15T05:59:26Z

stable/influxdb/templates/statefulset.yaml

@@ -139,6 +139,10 @@ spec:
  volumeClaimTemplates:
    - metadata:
        name: {{ template "influxdb.fullname" . }}-data


With label helpers added in 4.0.0 of the chart, you can now do something like:

metadata: name: {{ include "influxdb.fullname" . }}-data labels: {{- include "influxdb.labels" . | nindent 4 }}

davidkarlsen · 2020-03-04T09:24:39Z

This chart has been deprecated and moved: #21231

[stable/influxdb] Adds missing headless service configuration.

df3b134

Other modifications: 1. add release label to statefulset.yaml. 2. modify annotations syntax in values.yaml. Signed-off-by: spring-bu <bushengquan@gmail.com>

helm-bot added the Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). label Jan 20, 2020

k8s-ci-robot requested a review from Aisuko January 20, 2020 04:50

helm-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 20, 2020

k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 20, 2020

naseemkullah suggested changes Feb 15, 2020

View reviewed changes

davidkarlsen closed this Mar 4, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[stable/influxdb] Adds missing headless service configuration. #20237

[stable/influxdb] Adds missing headless service configuration. #20237

hydra-bu commented Jan 20, 2020

k8s-ci-robot commented Jan 20, 2020

k8s-ci-robot commented Jan 20, 2020

naseemkullah Feb 15, 2020 •

edited

Loading

naseemkullah Feb 15, 2020

naseemkullah Feb 15, 2020

naseemkullah Feb 15, 2020

naseemkullah Feb 15, 2020

naseemkullah Feb 15, 2020

naseemkullah Feb 15, 2020

naseemkullah Feb 15, 2020

naseemkullah Feb 15, 2020

davidkarlsen commented Mar 4, 2020

	app: {{ template "influxdb.fullname" . }}
	{{- include "influxdb.selectorLabels" . \| nindent 4 }}

[stable/influxdb] Adds missing headless service configuration. #20237

[stable/influxdb] Adds missing headless service configuration. #20237

Conversation

hydra-bu commented Jan 20, 2020

Is this a new chart

What this PR does / why we need it:

Which issue this PR fixes

Special notes for your reviewer:

Checklist

k8s-ci-robot commented Jan 20, 2020

k8s-ci-robot commented Jan 20, 2020

naseemkullah Feb 15, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

davidkarlsen commented Mar 4, 2020

naseemkullah Feb 15, 2020 •

edited

Loading