Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/verdaccio] Add myself as maintainer and update home domain and icon #20396

Closed
wants to merge 1 commit into from
Closed

[stable/verdaccio] Add myself as maintainer and update home domain and icon #20396

wants to merge 1 commit into from

Conversation

juanpicado
Copy link
Contributor

@juanpicado juanpicado commented Jan 28, 2020 •
edited
Loading

Is this a new chart

NOTE: We're experiencing a high volume of PRs to this repo and reviews will be delayed. Please host your own chart repository and submit your repository to the Helm Hub instead of this repo to make them discoverable to the community. Here is how to submit new chart repositories to the Helm Hub.

No

What this PR does / why we need it:

Add maintainer

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

Special notes for your reviewer:

I maintain the Verdaccio project.

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md
  • Title of the PR starts with chart name (e.g. [stable/mychartname])

@helm-bot helm-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 28, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: juanpicado
To complete the pull request process, please assign prydonius
You can assign the PR to them by writing /assign @prydonius in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

Hi @juanpicado. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 28, 2020
@juanpicado
Add myself as mantainer and update home domain and icon
c1ce35f 
Signed-off-by: Juan Picado @jotadeveloper <juanpicado19@gmail.com>
@helm-bot helm-bot added the Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). label Jan 28, 2020
@maorfr
Copy link
Member

maorfr commented Jan 31, 2020

can @scottrigby take a look?

@zanhsieh
Copy link
Collaborator

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 27, 2020
@juanpicado
Copy link
Contributor Author

/retest

@juanpicado
Copy link
Contributor Author

Test are failing after retry? Could someone help me what I'm suppose to do now?

@stale
Copy link

stale bot commented Mar 28, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions.

@stale stale bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 28, 2020
@juanpicado
Copy link
Contributor Author

Well, I'm still waiting for what to do, so please bot un-stale.

@stale stale bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 28, 2020
@juanpicado
Copy link
Contributor Author

/retest

@k8s-ci-robot
Copy link
Contributor

@juanpicado: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-charts-e2e c1ce35f link /test pull-charts-e2e

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kav
Copy link
Contributor

kav commented Apr 2, 2020

@juanpicado it seems like the stable repo is getting sunset in favor of orgs owning their own repos https://github.com/helm/charts#deprecation-timeline
If you make a new repo under the Verdaccio org and add me as a maintainer for that repo I'd be happy to poke around getting that set up for you as the existing chart needs some clean up, even just regarding documentation. Also happy to work in a folder in https://github.com/verdaccio/verdaccio and PR if you like.

@juanpicado
Copy link
Contributor Author

@juanpicado it seems like the stable repo is getting sunset in favor of orgs owning their own repos https://github.com/helm/charts#deprecation-timeline
If you make a new repo under the Verdaccio org and add me as a maintainer for that repo I'd be happy to poke around getting that set up for you as the existing chart needs some clean up, even just regarding documentation. Also happy to work in a folder in https://github.com/verdaccio/verdaccio and PR if you like.

Let's do it, I'll setup a new repo, I wonder how we are suppose to publish Helm charts from there?

@kav
Copy link
Contributor

kav commented Apr 4, 2020

Just gotta setup github packages and then add the repo to helm hub

https://github.com/features/packages
https://github.com/helm/hub

@juanpicado juanpicado mentioned this pull request Apr 5, 2020
Closed
@juanpicado
Copy link
Contributor Author

Just gotta setup github packages and then add the repo to helm hub

https://github.com/features/packages
https://github.com/helm/hub

Let's keep discussing here verdaccio/verdaccio#1767 , please help me to describe the list of things we need to finish in order to accomplish this task

@juanpicado juanpicado closed this Apr 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@maorfr maorfr Awaiting requested review from maorfr

@viglesiasce viglesiasce Awaiting requested review from viglesiasce

Assignees
No one assigned
Labels
Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). ok-to-test size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Call for maintainers for charts with no OWNERS
6 participants
@juanpicado @k8s-ci-robot @maorfr @zanhsieh @kav @helm-bot